[IMP] mail: add test for link preview #162398
Conversation
taqu-odoo
force-pushed
the
saas-16.4-16.0-opw-3776565-mail_preview_link-taqu-sCVQ-fw
branch
from
1dc6f72
to
17ac5f7
Compare
taqu-odoo
changed the title
taqu-odoo
force-pushed
the
saas-16.4-16.0-opw-3776565-mail_preview_link-taqu-sCVQ-fw
branch
from
17ac5f7
to
41de55a
Compare
There was a problem hiding this comment.
looks good to me
looking just at the commit, this seems like a random test out of nowhere
it would be good to say in the commit message that this is a forward-port of the test of this saas-16.3 commit 5d5752e that was not merged because the issue was already fixed in saas-16.4 with bc202e0
robodoo delegate+
side note: usually in this case you could just reopen the closed forward-port (#162365) and update it to have only the test inside the commit and merge that.
it's ok like to open a new branch like this, but just slightly more noiseful (since a review is needed and people are pinged for something already reviewed)
taqu-odoo
force-pushed
the
saas-16.4-16.0-opw-3776565-mail_preview_link-taqu-sCVQ-fw
branch
from
41de55a
to
0eaa4e5
Compare
|
Hello, maybe one of you should r+ the PR? I didn't check the PR originally but this is still open in my notifications! |
|
@robodoo override=ci/security Reason: #157666 (comment) (manual forward port of leftover) |
|
@robodoo r+ |
Forward-port of the test from 5d5752e Add a test in case we try to generate a link preview and we don't get a 'Content-Type' in the headers of the response. This potential issue was addressed by bc202e0, we now also add a test. closes #162398 Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
Forward-port of the test from 5d5752e Add a test in case we try to generate a link preview and we don't get a 'Content-Type' in the headers of the response. This potential issue was addressed by bc202e0, we now also add a test. closes #162398 Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
Forward-port of the test from 5d5752e Add a test in case we try to generate a link preview and we don't get a 'Content-Type' in the headers of the response. This potential issue was addressed by bc202e0, we now also add a test. closes #162398 Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
|
@taqu-odoo @tde-banana-odoo staging failed: ci/upgrade_enterprise (view more at https://runbot.odoo.com/runbot/build/62550259) |
|
@robodoo retry |
Forward-port of the test from 5d5752e Add a test in case we try to generate a link preview and we don't get a 'Content-Type' in the headers of the response. This potential issue was addressed by bc202e0, we now also add a test. closes #162398 Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
|
@taqu-odoo @tde-banana-odoo this pull request has forward-port PRs awaiting action (not merged or closed): |
1 similar comment
|
@taqu-odoo @tde-banana-odoo this pull request has forward-port PRs awaiting action (not merged or closed): |
|
@taqu-odoo @tde-banana-odoo this pull request has forward-port PRs awaiting action (not merged or closed): |
|
@taqu-odoo @tde-banana-odoo this pull request has forward-port PRs awaiting action (not merged or closed): |
1 similar comment
|
@taqu-odoo @tde-banana-odoo this pull request has forward-port PRs awaiting action (not merged or closed): |
|
@taqu-odoo @tde-banana-odoo this pull request has forward-port PRs awaiting action (not merged or closed): |
2 similar comments
|
@taqu-odoo @tde-banana-odoo this pull request has forward-port PRs awaiting action (not merged or closed): |
|
@taqu-odoo @tde-banana-odoo this pull request has forward-port PRs awaiting action (not merged or closed): |
fw-bot
deleted the
saas-16.4-16.0-opw-3776565-mail_preview_link-taqu-sCVQ-fw
branch
Forward-port of the test from 5d5752e
Add a test in case we try to generate a link preview
and we don't get a 'Content-Type' in the headers of the
response.
This potential issue was addressed by bc202e0,
we now also add a test.