New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] website_sale: use separate contact for pick-up point #162399
Conversation
f1042d1
to
e7a2e3b
Compare
a1dbdd0
to
dccffa4
Compare
dccffa4
to
820c8b9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello,
Thank you for your work!
Here is one suggestion for improvement, wdyt?
820c8b9
to
d13f25e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the bug only there from 17.0 ? If so, why?
Steps to reproduce: 1. Configure Sendcloud shipping with pick-up locations 2. Go to website and use the shipping method and select a pick-up location 3. Try step 2 again, using the same pick-up point but with a different name 4. Checking the delivery address of the second customer, we see the name of the first customer is used The problem is that if a pick-up location is already saved, we re-use the same contact for the delivery address. This commit ensures separate contacts are created for different customers. opw-3853716
d13f25e
to
25d9f6c
Compare
Making a new PR to target saas-16.3 #162950 |
There is no need to close this PR and create a new one for each version. You could have rebased this one and retargeted to 15.0. The fw-bot will take care to propagate your changes to all versions up to master. |
Steps to reproduce:
The problem is that if a pick-up location is already saved, we re-use the same contact for the delivery address. This commit ensures separate contacts are created for different customers.
opw-3853716
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr