Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] website_sale: use separate contact for pick-up point #162399

Closed
wants to merge 1 commit into from

Conversation

khah-odoo
Copy link
Contributor

Steps to reproduce:

  1. Configure Sendcloud shipping with pick-up locations
  2. Go to website and use the shipping method and select a pick-up location
  3. Try step 2 again, using the same pick-up point but with a different name
  4. Checking the delivery address of the second customer, we see the name of the first customer is used

The problem is that if a pick-up location is already saved, we re-use the same contact for the delivery address. This commit ensures separate contacts are created for different customers.

opw-3853716


I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@robodoo
Copy link
Contributor

robodoo commented Apr 18, 2024

@C3POdoo C3POdoo requested a review from a team April 18, 2024 11:30
@khah-odoo khah-odoo force-pushed the 17.0-opw-3853716-khah branch 3 times, most recently from a1dbdd0 to dccffa4 Compare April 18, 2024 11:37
@Feyensv Feyensv requested review from a team and removed request for a team April 18, 2024 11:39
@C3POdoo C3POdoo added the OE the report is linked to a support ticket (opw-...) label Apr 18, 2024
@khah-odoo khah-odoo requested a review from Dotni April 18, 2024 13:08
Copy link
Contributor

@Dotni Dotni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @khah-odoo 👋

The code looks good to me, well done!

@amoyaux can you take a look as well?

Copy link
Contributor

@vchu-odoo vchu-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello,

Thank you for your work!

Here is one suggestion for improvement, wdyt?

addons/website_sale/models/sale_order.py Outdated Show resolved Hide resolved
Copy link
Contributor

@vchu-odoo vchu-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@vchu-odoo vchu-odoo requested a review from Feyensv April 19, 2024 09:17
Copy link
Contributor

@Feyensv Feyensv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the bug only there from 17.0 ? If so, why?

Steps to reproduce:
1. Configure Sendcloud shipping with pick-up locations
2. Go to website and use the shipping method and select a
pick-up location
3. Try step 2 again, using the same pick-up point but with a
different name
4. Checking the delivery address of the second customer, we
see the name of the first customer is used

The problem is that if a pick-up location is already saved,
we re-use the same contact for the delivery address. This
commit ensures separate contacts are created for different
customers.

opw-3853716
@khah-odoo
Copy link
Contributor Author

Making a new PR to target saas-16.3 #162950

@vchu-odoo
Copy link
Contributor

There is no need to close this PR and create a new one for each version. You could have rebased this one and retargeted to 15.0. The fw-bot will take care to propagate your changes to all versions up to master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OE the report is linked to a support ticket (opw-...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants