[FIX] mrp_account: bypass the timesheet analytic access rule for MRP #162409
+36
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lase-odoo
force-pushed
the
15.0-opw-3836624-mark_done_MO_with_analytic_account-lase
branch
3 times, most recently
from
47ca614
to
7fe2819
Compare
nle-odoo
approved these changes
Apr 29, 2024
| @@ -4,6 +4,7 @@ | |||
| from odoo.addons.mrp.tests.common import TestMrpCommon | |||
| from odoo.addons.stock_account.tests.test_account_move import TestAccountMove | |||
| from odoo.tests import Form, tagged | |||
| from odoo import Command | |||
There was a problem hiding this comment.
should be first of the from odoo normally
lase-odoo
force-pushed
the
15.0-opw-3836624-mark_done_MO_with_analytic_account-lase
branch
from
7fe2819
to
97e1e13
Compare
|
I would |
|
@Whenrow the error is actually raised when the action returned by the |
lase-odoo
force-pushed
the
15.0-opw-3836624-mark_done_MO_with_analytic_account-lase
branch
from
97e1e13
to
3c52509
Compare
…flows Steps to reproduce: - Go to settings and activate Analytic Accounting - Create a product with a BOM - In the Miscellaneous tab of the BOM, add: [ASML - HOUR] Costing Account For Hours of Assembly as analytic account. - Settings > Users and companies > Users - Change the access rights of Marc Demo to: - Timesheets: User: own timesheets only - Accounting: None - Connect as mark Demo and create an manufactoring order with your BOM - "Confirm" the MO and "Mark as Done": > Access Error: you are not allowed to modify 'Analytic Line' Cause of the issue: The error is raised due to the ir.rule: "account.analytic.line.timesheet.user.update-unlink": https://github.com/odoo/enterprise/blob/c5ab16b0464cc396fdb02f3968d3d61e68f7cb2e/timesheet_grid/security/timesheet_security.xml#L12-L28 as the analytic lines created from the MO will not be linked to a project and will therefore never pass the domain. opw-3836624
lase-odoo
force-pushed
the
15.0-opw-3836624-mark_done_MO_with_analytic_account-lase
branch
from
3c52509
to
511fd3c
Compare
|
robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
Jun 6, 2024
…flows Steps to reproduce: - Go to settings and activate Analytic Accounting - Create a product with a BOM - In the Miscellaneous tab of the BOM, add: [ASML - HOUR] Costing Account For Hours of Assembly as analytic account. - Settings > Users and companies > Users - Change the access rights of Marc Demo to: - Timesheets: User: own timesheets only - Accounting: None - Connect as mark Demo and create an manufactoring order with your BOM - "Confirm" the MO and "Mark as Done": > Access Error: you are not allowed to modify 'Analytic Line' Cause of the issue: The error is raised due to the ir.rule: "account.analytic.line.timesheet.user.update-unlink": https://github.com/odoo/enterprise/blob/c5ab16b0464cc396fdb02f3968d3d61e68f7cb2e/timesheet_grid/security/timesheet_security.xml#L12-L28 as the analytic lines created from the MO will not be linked to a project and will therefore never pass the domain. opw-3836624 closes #162409 Signed-off-by: William Henrotin (whe) <whe@odoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps to reproduce:
> Access Error: you are not allowed to modify 'Analytic Line'
Cause of the issue:
The error is raised due to the ir.rule:
"account.analytic.line.timesheet.user.update-unlink": https://github.com/odoo/enterprise/blob/c5ab16b0464cc396fdb02f3968d3d61e68f7cb2e/timesheet_grid/security/timesheet_security.xml#L12-L28
as the analytic lines created from the MO will not be linked to a project and will therefore never pass the domain.
opw-3836624
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr