[FIX] calendar: close the popup after deletion #162411
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Steps to reproduce: - open the Calendar module - make sure google sync is enabled - when to click on a event, a popup appears - when you press on delete, a confirmation message is shown but the popup is not closed Issue: The popup is not disappearing which allows the user to click multiple times on the delete option which can cause error when the user confirm the deletion as the user cannot delete a deleted record. Cause: When google sync is enabled the event becomes achievable so when you delete the event instead of onDeleteEvent() function of CalendarCommonPopover component the onClickArchive() of AttendeeCalendarCommonPopover is called which do not handle the closing of the popup. Solution: In the onClickArchive() function, call the close function which is passed in the props of the parent component. task-3875211
|
@robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
Jun 6, 2024
Steps to reproduce: - open the Calendar module - make sure google sync is enabled - when to click on a event, a popup appears - when you press on delete, a confirmation message is shown but the popup is not closed Issue: The popup is not disappearing which allows the user to click multiple times on the delete option which can cause error when the user confirm the deletion as the user cannot delete a deleted record. Cause: When google sync is enabled the event becomes achievable so when you delete the event instead of onDeleteEvent() function of CalendarCommonPopover component the onClickArchive() of AttendeeCalendarCommonPopover is called which do not handle the closing of the popup. Solution: In the onClickArchive() function, call the close function which is passed in the props of the parent component. task-3875211 closes #162411 Signed-off-by: Arnaud Joset (arj) <arj@odoo.com>
This was referenced Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version:
16.0
Steps to reproduce:
Issue:
The popup is not disappearing which allows the user to click multiple times on the delete option which can cause error when the user confirm the deletion as the user cannot delete a deleted record.
Cause:
When google sync is enabled the event becomes achievable so when you delete the event instead of onDeleteEvent() function of CalendarCommonPopover component the onClickArchive() of AttendeeCalendarCommonPopover is called which do not handle the closing of the popup.
Solution:
In the onClickArchive() function, call the close function which is passed in the props of the parent component.
task-3875211
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr