New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IMP] l10n_din5008: address display and footer size #162557
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this commit, we always had the address of the partner even if the address were the same. Now, depending on the address in the customer field or delivery address, we can decide to display the invoicing address or shipping address or both. task: 3817563
General scaling of the footer font is too big. Normal Sized company names cannot be displayed. In Fact, the Iban numbers etc. are cut off at the bottom. This commit will reduce the size of the footer. task-3192117
Levizar
approved these changes
Apr 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@robodoo r+
@malb-odoo @Levizar because this PR has multiple commits, I need to know how to merge it:
|
@robodoo rebase-ff |
Merge method set to rebase and fast-forward. |
robodoo
pushed a commit
that referenced
this pull request
Apr 19, 2024
Before this commit, we always had the address of the partner even if the address were the same. Now, depending on the address in the customer field or delivery address, we can decide to display the invoicing address or shipping address or both. Task: 3817563 Part-of: #162557
robodoo
pushed a commit
that referenced
this pull request
Apr 19, 2024
General scaling of the footer font is too big. Normal Sized company names cannot be displayed. In Fact, the Iban numbers etc. are cut off at the bottom. This commit will reduce the size of the footer. task-3192117 closes #162557 Signed-off-by: Brice Bartoletti (bib) <bib@odoo.com>
robodoo
pushed a commit
that referenced
this pull request
Apr 19, 2024
Before this commit, we always had the address of the partner even if the address were the same. Now, depending on the address in the customer field or delivery address, we can decide to display the invoicing address or shipping address or both. Task: 3817563 Part-of: #162557
This was referenced Apr 20, 2024
goffauxs
pushed a commit
to odoo-dev/odoo
that referenced
this pull request
Apr 25, 2024
Before this commit, we always had the address of the partner even if the address were the same. Now, depending on the address in the customer field or delivery address, we can decide to display the invoicing address or shipping address or both. Task: 3817563 Part-of: odoo#162557
goffauxs
pushed a commit
to odoo-dev/odoo
that referenced
this pull request
Apr 25, 2024
General scaling of the footer font is too big. Normal Sized company names cannot be displayed. In Fact, the Iban numbers etc. are cut off at the bottom. This commit will reduce the size of the footer. task-3192117 closes odoo#162557 Signed-off-by: Brice Bartoletti (bib) <bib@odoo.com>
willylohws
pushed a commit
to willylohws/odoo
that referenced
this pull request
May 1, 2024
Before this commit, we always had the address of the partner even if the address were the same. Now, depending on the address in the customer field or delivery address, we can decide to display the invoicing address or shipping address or both. Task: 3817563 Part-of: odoo#162557
willylohws
pushed a commit
to willylohws/odoo
that referenced
this pull request
May 1, 2024
General scaling of the footer font is too big. Normal Sized company names cannot be displayed. In Fact, the Iban numbers etc. are cut off at the bottom. This commit will reduce the size of the footer. task-3192117 closes odoo#162557 Signed-off-by: Brice Bartoletti (bib) <bib@odoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit is about the display of the address block, we always had the address of the partner even if the address
were the same. Now, depending on the address in the customer field or delivery address, we can
decide to display the invoicing address or shipping address or both.
The other one is about the size of the footer because the general scaling of the footer font is too big. Normal Sized company names cannot be displayed. In Fact, the Iban numbers etc. are cut off at the bottom.
task: 3817563
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr