Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] l10n_din5008: address display and footer size #162557

Closed

Conversation

malb-odoo
Copy link
Contributor

The first commit is about the display of the address block, we always had the address of the partner even if the address
were the same. Now, depending on the address in the customer field or delivery address, we can
decide to display the invoicing address or shipping address or both.

The other one is about the size of the footer because the general scaling of the footer font is too big. Normal Sized company names cannot be displayed. In Fact, the Iban numbers etc. are cut off at the bottom.

task: 3817563


I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Before this commit, we always had the address of the partner even if the address
were the same.
Now, depending on the address in the customer field or delivery address, we can
decide to display the invoicing address or shipping address or both.

task: 3817563
General scaling of the footer font is too big. Normal Sized company names cannot
be displayed. In Fact, the Iban numbers etc. are cut off at the bottom.
This commit will reduce the size of the footer.

task-3192117
@malb-odoo malb-odoo requested a review from Levizar April 19, 2024 06:49
@robodoo
Copy link
Contributor

robodoo commented Apr 19, 2024

@C3POdoo C3POdoo added the RD research & development, internal work label Apr 19, 2024
Copy link
Contributor

@Levizar Levizar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@robodoo
Copy link
Contributor

robodoo commented Apr 19, 2024

@malb-odoo @Levizar because this PR has multiple commits, I need to know how to merge it:

  • merge to merge directly, using the PR as merge commit message
  • rebase-merge to rebase and merge, using the PR as merge commit message
  • rebase-ff to rebase and fast-forward

@Levizar
Copy link
Contributor

Levizar commented Apr 19, 2024

@robodoo rebase-ff

@robodoo
Copy link
Contributor

robodoo commented Apr 19, 2024

Merge method set to rebase and fast-forward.

robodoo pushed a commit that referenced this pull request Apr 19, 2024
Before this commit, we always had the address of the partner even if the address
were the same.
Now, depending on the address in the customer field or delivery address, we can
decide to display the invoicing address or shipping address or both.

Task: 3817563
Part-of: #162557
robodoo pushed a commit that referenced this pull request Apr 19, 2024
General scaling of the footer font is too big. Normal Sized company names cannot
be displayed. In Fact, the Iban numbers etc. are cut off at the bottom.
This commit will reduce the size of the footer.

task-3192117

closes #162557

Signed-off-by: Brice Bartoletti (bib) <bib@odoo.com>
robodoo pushed a commit that referenced this pull request Apr 19, 2024
Before this commit, we always had the address of the partner even if the address
were the same.
Now, depending on the address in the customer field or delivery address, we can
decide to display the invoicing address or shipping address or both.

Task: 3817563
Part-of: #162557
@robodoo robodoo closed this in 2d323aa Apr 20, 2024
goffauxs pushed a commit to odoo-dev/odoo that referenced this pull request Apr 25, 2024
Before this commit, we always had the address of the partner even if the address
were the same.
Now, depending on the address in the customer field or delivery address, we can
decide to display the invoicing address or shipping address or both.

Task: 3817563
Part-of: odoo#162557
goffauxs pushed a commit to odoo-dev/odoo that referenced this pull request Apr 25, 2024
General scaling of the footer font is too big. Normal Sized company names cannot
be displayed. In Fact, the Iban numbers etc. are cut off at the bottom.
This commit will reduce the size of the footer.

task-3192117

closes odoo#162557

Signed-off-by: Brice Bartoletti (bib) <bib@odoo.com>
willylohws pushed a commit to willylohws/odoo that referenced this pull request May 1, 2024
Before this commit, we always had the address of the partner even if the address
were the same.
Now, depending on the address in the customer field or delivery address, we can
decide to display the invoicing address or shipping address or both.

Task: 3817563
Part-of: odoo#162557
willylohws pushed a commit to willylohws/odoo that referenced this pull request May 1, 2024
General scaling of the footer font is too big. Normal Sized company names cannot
be displayed. In Fact, the Iban numbers etc. are cut off at the bottom.
This commit will reduce the size of the footer.

task-3192117

closes odoo#162557

Signed-off-by: Brice Bartoletti (bib) <bib@odoo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RD research & development, internal work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants