[FW] Saas 17.1 hr fix same user creation mepe #162602
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mepe-odoo @sofiagvaladze cherrypicking of pull request #159860 failed. stdout: stderr: Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?). In the former case, you may want to edit this PR message as well. More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
robodoo
added
forwardport
STEP TO REPRODUCE:
==================
* Go on Employees application
* Click on new
* Set a name
* Click on Hr Settings
* Set Mitchell Admin as Related User
* Click on backup cloud
You will have a traceback about an sql constraint violation.
Expected behaviour:
===================
You should get a validation error with the sql constraint message.
Similar behaviour:
==================
When you try to do the same thing but with an existing employee you will
have this validation error and not the traceback.
Issue explanation:
==================
To ensure that only one employee per company is linked to a user; the
sql constraint user_uniq has been created. In the constraint only the fields
user_id and company_id are checked.
But the field user_id is realted to the resource's user_id and stored.
So when creating employee; the record will be created without a user_id.
Right after, a security rule linked to user_id will be checked. This
ir.rule will trigger the computation of user_id. The safe_eval function
will catch the validation error and instead of raising this validation
error will raise a value error with the validation error as the message.
And this, value error will raise the traceback.
Resolution:
===========
If the field user_id is pre-compute, the error will be raise during the
creation and not during the security rule's check.
Task: 3834561
X-original-commit: cce4207
mepe-odoo
force-pushed
the
saas-17.2-saas-17.1-hr-fix_same_user_creation-mepe-JGdn-fw
branch
from
a1d4154
to
87cfc6e
Compare
|
@robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
Apr 19, 2024
STEP TO REPRODUCE:
==================
* Go on Employees application
* Click on new
* Set a name
* Click on Hr Settings
* Set Mitchell Admin as Related User
* Click on backup cloud
You will have a traceback about an sql constraint violation.
Expected behaviour:
===================
You should get a validation error with the sql constraint message.
Similar behaviour:
==================
When you try to do the same thing but with an existing employee you will
have this validation error and not the traceback.
Issue explanation:
==================
To ensure that only one employee per company is linked to a user; the
sql constraint user_uniq has been created. In the constraint only the fields
user_id and company_id are checked.
But the field user_id is realted to the resource's user_id and stored.
So when creating employee; the record will be created without a user_id.
Right after, a security rule linked to user_id will be checked. This
ir.rule will trigger the computation of user_id. The safe_eval function
will catch the validation error and instead of raising this validation
error will raise a value error with the validation error as the message.
And this, value error will raise the traceback.
Resolution:
===========
If the field user_id is pre-compute, the error will be raise during the
creation and not during the security rule's check.
closes #162602
Task: 3834561
X-original-commit: cce4207
Signed-off-by: Sofie Gvaladze (sgv) <sgv@odoo.com>
Signed-off-by: Mélanie Peyrat (mepe) <mepe@odoo.com>
fw-bot
deleted the
saas-17.2-saas-17.1-hr-fix_same_user_creation-mepe-JGdn-fw
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses:
Current behavior before PR:
Desired behavior after PR is merged:
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Forward-Port-Of: #159860