Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] mrp_workorder: workorder total duration #162607

Closed

Conversation

HANNICHE-Walid
Copy link
Member

@HANNICHE-Walid HANNICHE-Walid commented Apr 19, 2024

Steps to reproduce:
Log multiple overlaping durations on a workorder

Bug:
total duration is wrong on the WO modal displaying the sum is misleading since overlaping durations will be ignored and total duration (real duration) might be different

Fix:
removing sum at the end (replace with real duration eventually)
opw-3768645

@robodoo
Copy link
Contributor

robodoo commented Apr 19, 2024

@C3POdoo C3POdoo requested a review from a team April 19, 2024 12:22
@C3POdoo C3POdoo added the RD research & development, internal work label Apr 19, 2024
@HANNICHE-Walid HANNICHE-Walid marked this pull request as draft April 25, 2024 10:12
@HANNICHE-Walid HANNICHE-Walid changed the base branch from 17.0 to master April 25, 2024 10:12
@HANNICHE-Walid HANNICHE-Walid marked this pull request as ready for review April 25, 2024 10:19
@Whenrow
Copy link
Contributor

Whenrow commented Apr 26, 2024

Nice fix except this little css issue
image

@HANNICHE-Walid HANNICHE-Walid force-pushed the 17.0-fixUIdurationWoSum-waha branch 5 times, most recently from 6dcb1df to 0d3a9f4 Compare May 24, 2024 13:44
Steps to reproduce:
Log multiple overlaping durations on a workorder

Bug:
total duration is wrong on the WO modal displaying the sum is misleading
since overlaping durations will be ignored and total duration (real
duration) might be different

Fix:
removing sum at the end (replace with real duration eventually)
@Whenrow
Copy link
Contributor

Whenrow commented May 29, 2024

robodoo r+

robodoo pushed a commit that referenced this pull request May 29, 2024
Steps to reproduce:
Log multiple overlaping durations on a workorder

Bug:
total duration is wrong on the WO modal displaying the sum is misleading
since overlaping durations will be ignored and total duration (real
duration) might be different

Fix:
removing sum at the end (replace with real duration eventually)

closes #162607

Signed-off-by: William Henrotin (whe) <whe@odoo.com>
@robodoo robodoo closed this May 29, 2024
@robodoo robodoo added the 17.3 label May 29, 2024
visp-odoo pushed a commit to odoo-dev/odoo that referenced this pull request May 30, 2024
Steps to reproduce:
Log multiple overlaping durations on a workorder

Bug:
total duration is wrong on the WO modal displaying the sum is misleading
since overlaping durations will be ignored and total duration (real
duration) might be different

Fix:
removing sum at the end (replace with real duration eventually)

closes odoo#162607

Signed-off-by: William Henrotin (whe) <whe@odoo.com>
HANNICHE-Walid added a commit to odoo-dev/odoo that referenced this pull request May 31, 2024
Steps to reproduce:
Log multiple overlaping durations on a workorder

Bug:
total duration is wrong on the WO modal displaying the sum is misleading
since overlaping durations will be ignored and total duration (real
duration) might be different

Fix:
removing sum at the end (replace with real duration eventually)

closes odoo#162607

Signed-off-by: William Henrotin (whe) <whe@odoo.com>
HANNICHE-Walid added a commit to odoo-dev/odoo that referenced this pull request May 31, 2024
Steps to reproduce:
Log multiple overlaping durations on a workorder

Bug:
total duration is wrong on the WO modal displaying the sum is misleading
since overlaping durations will be ignored and total duration (real
duration) might be different

Fix:
removing sum at the end (replace with real duration eventually)

closes odoo#162607

Signed-off-by: William Henrotin (whe) <whe@odoo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
17.3 RD research & development, internal work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants