[FIX] web_editor: prevent insertion of link on ctrl+k with video focused #162615
+15
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
perm-odoo
force-pushed
the
15.0-fix-prevent-link-on-ctrlk-for-video-perm
branch
from
f46d835
to
38703bf
Compare
msh-odoo
force-pushed
the
15.0-fix-prevent-link-on-ctrlk-for-video-perm
branch
from
38703bf
to
9b21d5b
Compare
robinlej
requested changes
May 2, 2024
| @@ -1125,6 +1125,10 @@ const Wysiwyg = Widget.extend({ | |||
| core.bus.trigger('activate_image_link_tool'); | |||
| return; | |||
| } | |||
| // Avoid invoking toggleLinkTools for videos. | |||
| if (targetEl.parentNode.closest(".media_iframe_video")) { | |||
| return; | |||
There was a problem hiding this comment.
It looks like it works, but I'm afraid there is more to it than that.
If you:
- insert a video,
- click on it,
- Ctrl + A,
- Ctrl + K
=> it breaks the layout (the iframe's height is resized) and the DOM (a link tag is added and set around the whole video block structure, and the iframe is duplicated, once within the link tag, once outside of it).
You can then just click on the buggy iframe to reset it to fullsize, but you end up with 2 iframes in the DOM (you only see one because they're both positioned absolutely).
There was a problem hiding this comment.
Slightly different way to break things:
- Drop a text block
- Select all the paragraphs, and type
/videoto add one - Put your cursor on the text block (e.g. in the empty paragraph that should still be there under the video)
Ctrl + A, thenCtrl + K: you can add a link (and have a visual bug in passing)- Save
=> There are 2 iframes, this time both visible, and potentially a link only accessible if you click on the empty paragraph.
Note that I don't think preventing Ctrl + A would be the right solution: you might want to do it and then Delete to remove the video. (But ideally, Ctrl + A should select every editable content within the <section>, like what happens when you do it from inside a paragraph. Probably not for this task, though, unless it helps solve the Ctrl+K bug.)
perm-odoo
force-pushed
the
15.0-fix-prevent-link-on-ctrlk-for-video-perm
branch
3 times, most recently
from
47573dc
to
1a8db45
Compare
perm-odoo
force-pushed
the
15.0-fix-prevent-link-on-ctrlk-for-video-perm
branch
from
1a8db45
to
44091e9
Compare
This commit addresses an issue where selecting a video and pressing Ctrl+K would introduce a link(anchor tag) on top of the video. Also if the selection is section on Ctrl+A and Ctrl+K than whole section gets inside link. The fix ensures that pressing Ctrl+K while a video is focused will no longer insert a link and if section is in selection than avoid toggling link tools. task-2819776
perm-odoo
force-pushed
the
15.0-fix-prevent-link-on-ctrlk-for-video-perm
branch
from
44091e9
to
131ebac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses an issue where selecting a video and pressing Ctrl+K would introduce a link(anchor tag) on top of the video. The fix ensures that pressing Ctrl+K while a video is focused will no longer insert a link, resolving the issue of an empty link being added.
task-2819776