[FW][FIX] point_of_sale: set archived warehouse for pos type #162627
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR targets saas-17.1 and is part of the forward-port chain. Further PRs will be created up to master. More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
|
Hi @atp-odoo. Can you rebase for rebuild so that we can move forward with it? |
Found error during migration in customer database. when company is archived but will get that company on `self.env.company` of pos_config table, this error is generated when it's try to create the record for pos config from pos_resturant module by data file (defined on this commit) odoo@3236c1c as picking_type_id field in pos_config is required and we set default value by fetching warehouse for related company but here as company is archived, related warehouse is also archived and that why we didnot get picking_type_id for archived company and that will raise Error : ``` File "/home/odoo/src/odoo/17.0/odoo/models.py", line 4787, in _create cr.execute(SQL( File "/home/odoo/src/odoo/17.0/odoo/sql_db.py", line 332, in execute res = self._obj.execute(query, params) psycopg2.errors.NotNullViolation: null value in column "picking_type_id" of relation "pos_config" violates not-null constraint ``` X-original-commit: 34b9bf8
atp-odoo
force-pushed
the
saas-17.1-saas-16.4-fecth-archived-picking_type_id-atp-7-QW-fw
branch
from
d0f68ab
to
f6b4bba
Compare
|
@robodoo r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found error during migration in customer database. when company is archived but will get that company on
self.env.companyof pos_config table,this error is generated when it's try to create the record for pos config from pos_resturant module
by data file (defined on this commit)
3236c1c
as picking_type_id field in pos_config is required and we set default value by fetching warehouse for related company but here as company is archived, related warehouse is also archived and that why we didnot get picking_type_id for archived company and that will raise Error :
Description of the issue/feature this PR addresses:
Current behavior before PR:
Desired behavior after PR is merged:
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Forward-Port-Of: #151719