[FIX] pos_restaurant: prevent traceback on added table #162636
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: it was not reproducible in 17 (because of websocket probably). Checking the highest version with the issue... So need to be r+ only in version 16 :) |
qle-odoo
reviewed
Apr 19, 2024
addons/pos_restaurant/static/src/js/Screens/FloorScreen/FloorScreen.js
Outdated
Show resolved
Hide resolved
lse-odoo
force-pushed
the
16.0-pos_restaurant_warn_missing_table-lse
branch
3 times, most recently
from
ba566c8
to
f83a0c6
Compare
To reproduce (v16): 1. Install PoS Restaurant 2. Open the restaurant in a device D1 3. Open the restaurant in a device D2 4. From D1 create a new table => Traceback will keep appearing on D2: `cannot read propoertied of undefined (reading 'id')` This is a consequence of trying to set the order count on a table which is not synced (and will never be in 16 until a refresh) After this commit: This tables will be ignored and a warning in the console will appear opw-3850899
lse-odoo
force-pushed
the
16.0-pos_restaurant_warn_missing_table-lse
branch
from
f83a0c6
to
765bf75
Compare
|
fw-bot ignore |
|
Forward-port disabled. |
|
robodoo delegate+ |
|
@robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
Apr 19, 2024
To reproduce (v16): 1. Install PoS Restaurant 2. Open the restaurant in a device D1 3. Open the restaurant in a device D2 4. From D1 create a new table => Traceback will keep appearing on D2: `cannot read propoertied of undefined (reading 'id')` This is a consequence of trying to set the order count on a table which is not synced (and will never be in 16 until a refresh) After this commit: This tables will be ignored and a warning in the console will appear opw-3850899 closes #162636 Signed-off-by: Loan Sens (lse) <lse@odoo.com>
MohammedBasioni
pushed a commit
to odoo-dev/odoo
that referenced
this pull request
Apr 29, 2024
To reproduce (v16): 1. Install PoS Restaurant 2. Open the restaurant in a device D1 3. Open the restaurant in a device D2 4. From D1 create a new table => Traceback will keep appearing on D2: `cannot read propoertied of undefined (reading 'id')` This is a consequence of trying to set the order count on a table which is not synced (and will never be in 16 until a refresh) After this commit: This tables will be ignored and a warning in the console will appear opw-3850899 closes odoo#162636 Signed-off-by: Loan Sens (lse) <lse@odoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To reproduce (v16):
=> Traceback will keep appearing on D2:
cannot read propoertied of undefined (reading 'id')This is a consequence of trying to set the order count on a table which is not synced (and will never be in 16 until a refresh)
After this commit:
A console warning is logged and the POS proceed ignoring this missing tables
opw-3850899