[FW][FIX] sale: avoid traceback when editing SO company #162712
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue ----- When emptying the company field on a SO, a traceback happens if there's no customer set as there's no currency provided to _prepare_tax_totals (changed in 17.2 by ab0bdf0). Even if the company is a required field on a SO, the onchange will still be triggered if it is set to False, which causes the issue here. Fix ----- Provide a fallback currency in case the user deletes the company from the SO. opw-3859440 X-original-commit: 422261b
|
@taqu-odoo this PR targets master and is the last of the forward-port chain. To merge the full chain, use
More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
|
@fw-bot r+ |
robodoo
pushed a commit
that referenced
this pull request
Apr 22, 2024
Issue ----- When emptying the company field on a SO, a traceback happens if there's no customer set as there's no currency provided to _prepare_tax_totals (changed in 17.2 by ab0bdf0). Even if the company is a required field on a SO, the onchange will still be triggered if it is set to False, which causes the issue here. Fix ----- Provide a fallback currency in case the user deletes the company from the SO. opw-3859440 closes #162712 X-original-commit: 422261b Signed-off-by: Tanguy Quéguineur (taqu) <taqu@odoo.com>
zel-odoo
pushed a commit
to odoo-dev/odoo
that referenced
this pull request
Apr 29, 2024
Issue ----- When emptying the company field on a SO, a traceback happens if there's no customer set as there's no currency provided to _prepare_tax_totals (changed in 17.2 by ab0bdf0). Even if the company is a required field on a SO, the onchange will still be triggered if it is set to False, which causes the issue here. Fix ----- Provide a fallback currency in case the user deletes the company from the SO. opw-3859440 closes odoo#162712 X-original-commit: 422261b Signed-off-by: Tanguy Quéguineur (taqu) <taqu@odoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
When emptying the company field on a SO, a traceback
happens if there's no customer set as there's no currency
provided to _prepare_tax_totals (changed in 17.2 by
ab0bdf0).
Even if the company is a required field on a SO, the
onchange will still be triggered if it is set to False,
which causes the issue here.
Fix
Provide a fallback currency in case the user deletes
the company from the SO.
opw-3859440
Forward-Port-Of: #162037