[FIX] web_editor: fix user avatar aspect-ratio #162743
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes an issue occurring in the `web_editor` when multiple users edit some content. Prior to this commit, the user avatar was not using any aspect-ratio rule, resulting in a stretch avatar if the uploaded image wasn't square. This commit fixes this issue by adding the `o_object_fit_cover` class to the image, ensuring a correct ratio no matter the format of the uploaded image. task-3877841
|
Hello @odoo/rd-framework-editor, another single line PR, ready for review 😶🌫️ Could you have a look? Thanks |
|
Thanks for the fix! @robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
Apr 22, 2024
This commit fixes an issue occurring in the `web_editor` when multiple users edit some content. Prior to this commit, the user avatar was not using any aspect-ratio rule, resulting in a stretch avatar if the uploaded image wasn't square. This commit fixes this issue by adding the `o_object_fit_cover` class to the image, ensuring a correct ratio no matter the format of the uploaded image. task-3877841 closes #162743 Signed-off-by: David Monjoie (dmo) <dmo@odoo.com>
robodoo
pushed a commit
that referenced
this pull request
Apr 22, 2024
This commit fixes an issue occurring in the `web_editor` when multiple users edit some content. Prior to this commit, the user avatar was not using any aspect-ratio rule, resulting in a stretch avatar if the uploaded image wasn't square. This commit fixes this issue by adding the `o_object_fit_cover` class to the image, ensuring a correct ratio no matter the format of the uploaded image. task-3877841 closes #162743 Signed-off-by: David Monjoie (dmo) <dmo@odoo.com>
This was referenced Apr 22, 2024
MohammedBasioni
pushed a commit
to odoo-dev/odoo
that referenced
this pull request
Apr 29, 2024
This commit fixes an issue occurring in the `web_editor` when multiple users edit some content. Prior to this commit, the user avatar was not using any aspect-ratio rule, resulting in a stretch avatar if the uploaded image wasn't square. This commit fixes this issue by adding the `o_object_fit_cover` class to the image, ensuring a correct ratio no matter the format of the uploaded image. task-3877841 closes odoo#162743 Signed-off-by: David Monjoie (dmo) <dmo@odoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
task-3877841
This PR fixes an issue occurring in the
web_editorwhen multiple users edit some content.Prior to this commit, the user avatar was not using any aspect-ratio rule, resulting in a stretch avatar if the uploaded image wasn't square.
This commit fixes this issue by adding the
o_object_fit_coverclass to the image, ensuring a correct ratio no matter the format of the uploaded image.