[FIX] website: fix recent static template typo #162757
Conversation
|
|
| @@ -25,7 +25,7 @@ export class FullscreenIndication extends Component { | |||
| } | |||
|
|
|||
| get fullScreenIndicationText() { | |||
| return markup(sprintf(escape(_t("Press %(key)s to exit full string")), "<span>esc</span>")); | |||
| return markup(sprintf(escape(_t("Press %(key)s to exit fullscreen")), "<span>esc</span>")); | |||
There was a problem hiding this comment.
| return markup(sprintf(escape(_t("Press %(key)s to exit fullscreen")), "<span>esc</span>")); | |
| return markup(sprintf(escape(_t("Press %(key)s to exit full screen")), "<span>esc</span>")); |
As before the mistake made 3 days ago with 0246153
|
Dear @rdeodoo |
rdeodoo
changed the title
There was a problem hiding this comment.
@robodoo r+ squash
Thank you for your fix, appreciated 👍
This squash command should be using the PR desc to replace the commit message, I adjusted a few things to fit a bit more our guidelines.
Note that X-original-commit is something supposed to be added on forward port only.
I referenced the commit using markdown link, and a more detailed title.
|
@rdeodoo you may want to rebuild or fix this PR as it has failed CI. |
|
Merge method set to squash. |
|
You actually need to sign the CLA in your commit https://github.com/odoo/odoo/blob/17.0/doc/cla/sign-cla.md |
addons/website/static/src/components/fullscreen_indication/fullscreen_indication.js
Show resolved
Hide resolved
|
@rdeodoo |
|
@tsabi You have to do add an extra commit like #160844, not rewording the commit. See https://github.com/odoo/odoo/blob/17.0/doc/cla/sign-cla.md. |
|
@MiquelRForgeFlow All of these are me: I think the problem is that I don't have an email address in my commit, just my name. I just installed a new PyCharm, i will look how to set up that |
|
You are commiting here with email (...@bdsc.hu), which is different from the one in those corporate CLA (...@odootech.hu, ...@online-erp.hu, ...@i3rendszerhaz.hu). Maybe you should update a CLA, or do an individual CLA instead. |
tsabi
force-pushed
the
17.0-fix1
branch
2 times, most recently
from
d47615c
to
9207411
Compare
Recent commit 0246153 made a typo when converting templates: `full string` should be `full screen` --- I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
|
@robodoo override=ci/security |
|
@MiquelRForgeFlow |
|
Ty 👍 (I still prefer to use the PR desc as commit msg, not overflowing 72 char, absolute commit url and using markdown link) |
|
Merge method set to squash. |
Recent commit [1] made a typo when converting templates [1]: odoo@0246153 closes odoo#162757 Signed-off-by: Romain Derie (rde) <rde@odoo.com>
Recent commit 1 made a typo when converting templates