[FW][FIX] account: use proforma preview for non-printed invoices #162797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue ----- If an invoice is created, but not yet "Send & Print", the portal preview shows a normal invoice, but when "Download"ed from the portal preview, a proforma invoice is downloaded. The download behavior is intended since the client shouldn't be able to get a "final" invoice themselves, before the accountant generates one with "Send & Print". However, the HTML preview should also show a proforma invoice to be consistent with this, so the user downloads what they see. Steps ----- - Create a new invoice: Accounting -> Customers -> Invoices -> New -> ... - Go to portal by clicking on "Preview". - You'll see a normal invoice. Now click "Download". - A proforma invoice is downloaded. Cause ----- The HTML-rendered invoice in the portal preview isn't configured to be proforma. opw-3848049 X-original-commit: 588bf6b
|
|
|
This PR targets saas-17.1 and is part of the forward-port chain. Further PRs will be created up to master. More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
robodoo
pushed a commit
that referenced
this pull request
Apr 23, 2024
Issue ----- If an invoice is created, but not yet "Send & Print", the portal preview shows a normal invoice, but when "Download"ed from the portal preview, a proforma invoice is downloaded. The download behavior is intended since the client shouldn't be able to get a "final" invoice themselves, before the accountant generates one with "Send & Print". However, the HTML preview should also show a proforma invoice to be consistent with this, so the user downloads what they see. Steps ----- - Create a new invoice: Accounting -> Customers -> Invoices -> New -> ... - Go to portal by clicking on "Preview". - You'll see a normal invoice. Now click "Download". - A proforma invoice is downloaded. Cause ----- The HTML-rendered invoice in the portal preview isn't configured to be proforma. opw-3848049 closes #162797 X-original-commit: 588bf6b Signed-off-by: Claire Bretton (clbr) <clbr@odoo.com> Signed-off-by: Moataz Hussein (mohu) <mohu@odoo.com>
fw-bot
deleted the
saas-17.1-17.0-opw-3848049-iconsistent_portal_preview-mohu-TdA0-fw
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
If an invoice is created, but not yet "Send & Print", the portal preview shows a normal invoice, but when "Download"ed from the portal preview, a proforma invoice is downloaded. The download behavior is intended since the client shouldn't be able to get a "final" invoice themselves, before the accountant generates one with "Send & Print". However, the HTML preview should also show a proforma invoice to be consistent with this, so the user downloads what they see.
Steps
Cause
The HTML-rendered invoice in the portal preview isn't configured to be proforma.
opw-3848049
Forward-Port-Of: #161726