[FW][FIX] website_sale: fix conditional display of strikethrough price #162800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, if a product had `price < list_price` and `price < compare_list_price`, but `website_sale.group_product_price_comparison` unset, no strikethrough price was shown. However, in that case, we should show `list_price` as the strikethrough price. Previously, in the search dropdown, `compare_list_price` was only shown as the strikethrough price if `price < list_price` (which is unrelated). This change make it consistent with the product page. opw-3845926 X-original-commit: d769909
|
|
|
This PR targets saas-17.1 and is part of the forward-port chain. Further PRs will be created up to master. More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
robodoo
pushed a commit
that referenced
this pull request
Apr 22, 2024
Previously, if a product had `price < list_price` and `price < compare_list_price`, but `website_sale.group_product_price_comparison` unset, no strikethrough price was shown. However, in that case, we should show `list_price` as the strikethrough price. Previously, in the search dropdown, `compare_list_price` was only shown as the strikethrough price if `price < list_price` (which is unrelated). This change make it consistent with the product page. opw-3845926 closes #162800 X-original-commit: d769909 Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com> Signed-off-by: Louis Tinel (loti) <loti@odoo.com>
fw-bot
deleted the
saas-17.1-saas-16.3-fix-strikethrough-price-loti-KKel-fw
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if a product had
price < list_priceandprice < compare_list_price, butwebsite_sale.group_product_price_comparisonunset, no strikethrough price was shown. However, in that case, we should showlist_priceas the strikethrough price.Previously, in the search dropdown,
compare_list_pricewas only shown as the strikethrough price ifprice < list_price(which is unrelated). This change make it consistent with the product page.opw-3845926
Forward-Port-Of: #162611
Forward-Port-Of: #161473