Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] mrp_account: fix BoM creation test without demo data #162814

Conversation

pfertyk
Copy link
Contributor

@pfertyk pfertyk commented Apr 22, 2024

The test needs to set product_id field in order to check user's access. However, the field is not visible without enabling product variants, which makes the test fail in an environment with no demo data. This commit fixes the issue by adding the MRP manager to the 'product.group_product_variant' group.

The issue was introduced in #162107 .

Related build error:

https://runbot.odoo.com/web#id=61998&cids=1&menu_id=405&action=573&model=runbot.build.error&view_type=form

Description of the issue/feature this PR addresses:

Current behavior before PR:

Desired behavior after PR is merged:


I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

The test needs to set `product_id` field in order to check user's
access. However, the field is not visible without enabling product
variants, which makes the test fail in an environment with no demo data.
This commit fixes the issue by adding the MRP manager to the
'product.group_product_variant' group.

The issue was introduced in odoo#162107 .

Related build error:

https://runbot.odoo.com/web#id=61998&cids=1&menu_id=405&action=573&model=runbot.build.error&view_type=form
@robodoo
Copy link
Contributor

robodoo commented Apr 22, 2024

Pull request status dashboard.

@C3POdoo C3POdoo requested a review from a team April 22, 2024 11:33
@C3POdoo C3POdoo added the RD research & development, internal work label Apr 22, 2024
@amoyaux
Copy link
Contributor

amoyaux commented Apr 22, 2024

robodoo r+

robodoo pushed a commit that referenced this pull request Apr 22, 2024
The test needs to set `product_id` field in order to check user's
access. However, the field is not visible without enabling product
variants, which makes the test fail in an environment with no demo data.
This commit fixes the issue by adding the MRP manager to the
'product.group_product_variant' group.

The issue was introduced in #162107 .

Related build error:

https://runbot.odoo.com/web#id=61998&cids=1&menu_id=405&action=573&model=runbot.build.error&view_type=form

closes #162814

Signed-off-by: Arnold Moyaux (arm) <arm@odoo.com>
@robodoo robodoo closed this Apr 22, 2024
@fw-bot fw-bot deleted the saas-16.4-fix-mrp-account-tests-with-no-demo-pafe branch May 6, 2024 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RD research & development, internal work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants