[FW][FIX] stock: use precision_rounding instead of digits with float_is_zero #162823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Steps to reproduce the bug:
- Create a storable product “P1”
- UoM: gram
- Create an internal picking with 0.01g of P1
- Validate the picking
- Create a return and try to validate it
Problem:
A UserError is triggered: “Please specify at least one non-zero quantity.”
When creating a return, we check if the quantity is not zero using the
“float_is_zero” function, but we mistakenly use rounding as
precision_digits.
opw-3862142"
X-original-commit: daaa255
|
|
|
This PR targets saas-17.1 and is part of the forward-port chain. Further PRs will be created up to master. More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
robodoo
pushed a commit
that referenced
this pull request
Apr 23, 2024
Steps to reproduce the bug:
- Create a storable product “P1”
- UoM: gram
- Create an internal picking with 0.01g of P1
- Validate the picking
- Create a return and try to validate it
Problem:
A UserError is triggered: “Please specify at least one non-zero quantity.”
When creating a return, we check if the quantity is not zero using the
“float_is_zero” function, but we mistakenly use rounding as
precision_digits.
opw-3862142"
closes #162823
X-original-commit: daaa255
Signed-off-by: Quentin Wolfs (quwo) <quwo@odoo.com>
Signed-off-by: Djamel Touati (otd) <otd@odoo.com>
fw-bot
deleted the
saas-17.1-17.0-opw-3862142-stock-fix-float_is_zero-with-qty-returned-otd-zIrd-fw
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps to reproduce the bug:
Create a storable product “P1” - UoM: gram
Create an internal picking with 0.01g of P1
Validate the picking
Create a return and try to validate it
Problem:
A UserError is triggered: “Please specify at least one non-zero quantity.”
When creating a return, we check if the quantity is not zero using the “float_is_zero” function, but we mistakenly use rounding as precision_digits.
opw-3862142
Forward-Port-Of: #162389