[FW][FIX] web_editor: prevent visible traceback from non-blocking RTC error #162825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
__Current behavior before commit:__ Sometimes the following tracebacks are popping up when an RTC connection is being established between two users trying to edit the same document. ```log InvalidStateError: Failed to execute 'setLocalDescription' on 'RTCPeerConnection': Called in wrong signalingState: stable ``` ```log InvalidStateError: Failed to execute 'setRemoteDescription' on 'RTCPeerConnection': Called in wrong signalingState: stable ``` __Description of the fix:__ These errors are not blocking and don't impact the successful ensuing RTC connection. Thus, we can just catch the error and log it in the console instead of showing it to the user. __Steps to reproduce the issue (in 17):__ - Go to a knowledge article - Open a new tab and open the same article - On this new tab, quit the article and come back multiple times Eventually a traceback will appear on one of the tab. Note that this error seems to occur very randomly. It is similar to the one dealt by [this commit][1] and it is probably due to a similar cause i.e. a browser bug when the RTC connection is under stress. It is however possible to trigger it in a more consistent way by calling [_createClient][2] repeatedly. opw-3778272 [1]: odoo@0eca324 [2]: https://github.com/odoo/odoo/blob/a1afcc8/addons/web_editor/static/src/js/wysiwyg/PeerToPeer.js#L374 X-original-commit: cf0743a
|
|
|
This PR targets saas-17.1 and is part of the forward-port chain. Further PRs will be created up to master. More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
|
@fw-bot r+ |
robodoo
pushed a commit
that referenced
this pull request
Apr 23, 2024
__Current behavior before commit:__ Sometimes the following tracebacks are popping up when an RTC connection is being established between two users trying to edit the same document. ```log InvalidStateError: Failed to execute 'setLocalDescription' on 'RTCPeerConnection': Called in wrong signalingState: stable ``` ```log InvalidStateError: Failed to execute 'setRemoteDescription' on 'RTCPeerConnection': Called in wrong signalingState: stable ``` __Description of the fix:__ These errors are not blocking and don't impact the successful ensuing RTC connection. Thus, we can just catch the error and log it in the console instead of showing it to the user. __Steps to reproduce the issue (in 17):__ - Go to a knowledge article - Open a new tab and open the same article - On this new tab, quit the article and come back multiple times Eventually a traceback will appear on one of the tab. Note that this error seems to occur very randomly. It is similar to the one dealt by [this commit][1] and it is probably due to a similar cause i.e. a browser bug when the RTC connection is under stress. It is however possible to trigger it in a more consistent way by calling [_createClient][2] repeatedly. opw-3778272 [1]: 0eca324 [2]: https://github.com/odoo/odoo/blob/a1afcc8/addons/web_editor/static/src/js/wysiwyg/PeerToPeer.js#L374 closes #162825 X-original-commit: cf0743a Signed-off-by: David Monjoie (dmo) <dmo@odoo.com> Signed-off-by: Julien Launois (jula) <jula@odoo.com>
Dj0ulo
deleted the
saas-17.1-15.0-web_editor-prevent-visible-traceback-from-non-blocking-RTC-error-jula-b9GU-fw
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current behavior before commit:
Sometimes the following tracebacks are popping up when an RTC connection is being established between two users trying to edit the same document.
Description of the fix:
These errors are not blocking and don't impact the successful ensuing RTC connection. Thus, we can just catch the error and log it in the console instead of showing it to the user.
Steps to reproduce the issue (in 17):
Eventually a traceback will appear on one of the tab. Note that this error seems to occur very randomly. It is similar to the one dealt by this commit and it is probably due to a similar cause i.e. a browser bug when the RTC connection is under stress.
It is however possible to trigger it in a more consistent way by calling _createClient repeatedly.
opw-3778272
Forward-Port-Of: #162709
Forward-Port-Of: #161518