-
Notifications
You must be signed in to change notification settings - Fork 23.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IMP] payment(_paypal): add missing info #162837
[IMP] payment(_paypal): add missing info #162837
Conversation
d0356ac
to
e53e888
Compare
d43e5ba
to
8756ed3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello,
nice work!
LGTM 👍
Only some small nitpickings.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't forget to apply @vchu-odoo's review comments too :)
Removed rd-accounting review request since it's a small payment-only fix. |
d7f6e7e
to
9ba6429
Compare
KBC has been added to Mollie. Cards support refund. Refund is now checked based on payment method refund support, not brand. "Cleared" mapping has been added to done state in PayPal in order to properly support echeck. odoo-3880431
9ba6429
to
7b3d321
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@robodoo r+
KBC has been added to Mollie. Cards support refund. Refund is now checked based on payment method refund support, not brand. "Cleared" mapping has been added to done state in PayPal in order to properly support echeck. odoo-3880431 closes odoo#162837 Signed-off-by: Antoine Vandevenne (anv) <anv@odoo.com>
@anko-odoo @AntoineVDV this pull request has forward-port PRs awaiting action (not merged or closed): |
KBC has been added to Mollie.
Cards support refund.
Refund is now checked based on payment method refund support, not brand. "Cleared" mapping has been added to done state in PayPal in order to properly support echeck.
opw-3880431