Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] payment(_paypal): add missing info #162837

Closed

Conversation

anko-odoo
Copy link
Contributor

@anko-odoo anko-odoo commented Apr 22, 2024

KBC has been added to Mollie.
Cards support refund.
Refund is now checked based on payment method refund support, not brand. "Cleared" mapping has been added to done state in PayPal in order to properly support echeck.

opw-3880431

@robodoo
Copy link
Contributor

robodoo commented Apr 22, 2024

@anko-odoo anko-odoo force-pushed the 17.0-payment-methods-improvement-anko branch from d0356ac to e53e888 Compare April 22, 2024 12:55
@C3POdoo C3POdoo added the RD research & development, internal work label Apr 22, 2024
@anko-odoo anko-odoo force-pushed the 17.0-payment-methods-improvement-anko branch 2 times, most recently from d43e5ba to 8756ed3 Compare April 22, 2024 15:02
Copy link
Contributor

@vchu-odoo vchu-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello,
nice work!
LGTM 👍

Only some small nitpickings.

addons/account_payment/wizards/payment_refund_wizard.py Outdated Show resolved Hide resolved
addons/account_payment/models/account_payment.py Outdated Show resolved Hide resolved
addons/payment_paypal/const.py Show resolved Hide resolved
@AntoineVDV AntoineVDV marked this pull request as ready for review June 3, 2024 09:00
@C3POdoo C3POdoo requested review from a team and casp-odoo and removed request for a team June 3, 2024 09:16
Copy link
Contributor

@AntoineVDV AntoineVDV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to apply @vchu-odoo's review comments too :)

addons/payment_mollie/const.py Outdated Show resolved Hide resolved
addons/payment/data/payment_provider_data.xml Outdated Show resolved Hide resolved
addons/payment_paypal/const.py Show resolved Hide resolved
@AntoineVDV AntoineVDV removed the request for review from casp-odoo June 3, 2024 09:45
@AntoineVDV
Copy link
Contributor

Removed rd-accounting review request since it's a small payment-only fix.

@anko-odoo anko-odoo force-pushed the 17.0-payment-methods-improvement-anko branch 2 times, most recently from d7f6e7e to 9ba6429 Compare June 3, 2024 10:38
@anko-odoo anko-odoo requested a review from AntoineVDV June 3, 2024 10:43
KBC has been added to Mollie.
Cards support refund.
Refund is now checked based on payment method refund support, not brand.
"Cleared" mapping has been added to done state in PayPal in order to
properly support echeck.

odoo-3880431
@anko-odoo anko-odoo force-pushed the 17.0-payment-methods-improvement-anko branch from 9ba6429 to 7b3d321 Compare June 3, 2024 12:49
@anko-odoo
Copy link
Contributor Author

@AntoineVDV

Copy link
Contributor

@AntoineVDV AntoineVDV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@robodoo robodoo closed this in 4786349 Jun 3, 2024
lohwswilson pushed a commit to lohwswilson/odoo that referenced this pull request Jun 5, 2024
KBC has been added to Mollie.
Cards support refund.
Refund is now checked based on payment method refund support, not brand.
"Cleared" mapping has been added to done state in PayPal in order to
properly support echeck.

odoo-3880431

closes odoo#162837

Signed-off-by: Antoine Vandevenne (anv) <anv@odoo.com>
@fw-bot
Copy link
Contributor

fw-bot commented Jun 7, 2024

@anko-odoo @AntoineVDV this pull request has forward-port PRs awaiting action (not merged or closed):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RD research & development, internal work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants