[FW][FIX] im_livechat: fix chatbot test page translation #162858
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR fixes two translation issues when launching a chat bot with a different language than the user's: 1. Wrong translation for `question_selection` answers 2. Wrong translation for the `question_email` answers 1. The answers to a `question_selection` could be mistranslated because the lang is missing from the context when `post_welcome_steps` is called`. As a result, the `discuss.channel/new_message` notification would have the wrong answers format. Steps to reproduce the issue: - Go to the test chat bot test page - Switch the website language to the one that is not used by the user. - Check the return result of `post_welcome_steps`: answers are in the correct language. - Check the corresponding `discuss.channel/new_message` notification received through the websocket: the language is the one of the user. 2. The chat bot language is not specified when calling the `validate_email` route so the lang is the one of the user by default. Steps to reproduce the issue: - Go to the chat bot test page - Activate another language than the one of the user - Select "I have a pricing question" with no operator available - Enter an invalid email - The answer is in the user's language while it should not opw-3862125 X-original-commit: c9cfd25
|
|
|
This PR targets saas-17.1 and is part of the forward-port chain. Further PRs will be created up to master. More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
|
@tsm-odoo the next pull request (#162881) is in conflict. You can merge the chain up to here by saying
More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
|
@fw-bot r+ |
robodoo
pushed a commit
that referenced
this pull request
Apr 23, 2024
This PR fixes two translation issues when launching a chat bot with a different language than the user's: 1. Wrong translation for `question_selection` answers 2. Wrong translation for the `question_email` answers 1. The answers to a `question_selection` could be mistranslated because the lang is missing from the context when `post_welcome_steps` is called`. As a result, the `discuss.channel/new_message` notification would have the wrong answers format. Steps to reproduce the issue: - Go to the test chat bot test page - Switch the website language to the one that is not used by the user. - Check the return result of `post_welcome_steps`: answers are in the correct language. - Check the corresponding `discuss.channel/new_message` notification received through the websocket: the language is the one of the user. 2. The chat bot language is not specified when calling the `validate_email` route so the lang is the one of the user by default. Steps to reproduce the issue: - Go to the chat bot test page - Activate another language than the one of the user - Select "I have a pricing question" with no operator available - Enter an invalid email - The answer is in the user's language while it should not opw-3862125 closes #162858 X-original-commit: c9cfd25 Signed-off-by: Matthieu Stockbauer (tsm) <tsm@odoo.com>
fw-bot
deleted the
saas-17.1-17.0-im_livechat-fix_chatbot_test_translation-tsm-xZSI-fw
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes two translation issues when launching a chat bot with a different language than the user's:
question_selectionanswersquestion_emailanswersThe answers to a
question_selectioncould be mistranslated because thepost_welcome_stepsmethod overwrites the context's language when callingmessage_post. As a result, thediscuss.channel/new_messagenotification would have the wrong answers format.Steps to reproduce the issue:
post_welcome_steps: answers are in the correct language.discuss.channel/new_messagenotification received through the websocket: the language is the one of the user.The chat bot language is not specified when calling the
validate_emailroute so the lang is the one of the user by default.Steps to reproduce the issue:
opw-3862125
Forward-Port-Of: #162655