[FW][FIX] base: fix similar attachments #162917
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While searching for a similar attachment, as the fallback url pattern is the same as the url pattern, the condition is never satisfied. With this commit, the ignore_params parameter is used to find a similar attachment. X-original-commit: 29fb4ac
|
|
|
This PR targets saas-17.1 and is part of the forward-port chain. Further PRs will be created up to master. More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
robodoo
pushed a commit
that referenced
this pull request
Apr 22, 2024
While searching for a similar attachment, as the fallback url pattern is the same as the url pattern, the condition is never satisfied. With this commit, the ignore_params parameter is used to find a similar attachment. closes #162917 X-original-commit: 29fb4ac Signed-off-by: Xavier Dollé (xdo) <xdo@odoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While searching for a similar attachment, as the fallback url pattern is the same as the url pattern, the condition is never satisfied.
With this commit, the ignore_params parameter is used to find a similar attachment.
This was broken in a previous refactoring,
ignore_params=Truewas added at the wrong place breaking this mechanism.We also don't have to recompute the url in this case. If we didn't ignore the version, the url_pattern should be the exact url.
A test was adapted to test this fix.
Forward-Port-Of: #162654