[IMP] tests: autoretry and cursor commit #162990
Open
+95
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xavier-Do
force-pushed
the
master-autoretry-imps-xdo
branch
from
315a10c
to
ea6019e
Compare
C3POdoo
requested review from
a team,
HydrionBurst and
ryv-odoo
and removed request for
a team
xmo-odoo
requested changes
Apr 24, 2024
odoo/tests/common.py
Outdated
| break | ||
| if result.had_failure: | ||
| _logger.runbot('Disabling auto-retry after a failed test') | ||
| os.environ.pop('ODOO_TEST_FAILURE_RETRIES') |
There was a problem hiding this comment.
That's going to raise a KeyError if the envvar is not present, is that intended?
Also why not just lift this info to a global variable / counter if we're going to access it multiple times? That way this branch can just update the global.
Xavier-Do
force-pushed
the
master-autoretry-imps-xdo
branch
2 times, most recently
from
e1344db
to
b9f7307
Compare
|
@robodoo r+ |
|
@Xavier-Do you may want to rebuild or fix this PR as it has failed CI. |
|
@Xavier-Do because this PR has multiple commits, I need to know how to merge it:
|
|
@robodoo r+ |
|
I'm sorry, @Xavier-Do: this PR is already reviewed, reviewing it again is useless. |
|
@robodoo rebase-ff |
|
Merge method set to rebase and fast-forward. |
robodoo
pushed a commit
that referenced
this pull request
Apr 29, 2024
Commiting or rollbacking the cursor during test will lead to failure in cascade, because the cursor cannot be rollbacked at the end of the test, and cannot be closed proprely. In some case, it can even provoque failure on following test, maybe because some cleanup are not done proprely. This is also breaking the autoretry mecanism since the cursor cannot be rollbacked, leading to error not related to the first failure. Part-of: #162990
robodoo
pushed a commit
that referenced
this pull request
Apr 29, 2024
Auto retry is mainly useful to avoid the need to rebuild in case of random failure, but once one test failed, this mecanism is useless, creates noises in logs, increase laod by retrying test for no reason, ... This commit should disable this mecanism after the first error. closes #162990 Signed-off-by: Xavier Dollé (xdo) <xdo@odoo.com>
robodoo
pushed a commit
that referenced
this pull request
Apr 29, 2024
Commiting or rollbacking the cursor during test will lead to failure in cascade, because the cursor cannot be rollbacked at the end of the test, and cannot be closed proprely. In some case, it can even provoque failure on following test, maybe because some cleanup are not done proprely. This is also breaking the autoretry mecanism since the cursor cannot be rollbacked, leading to error not related to the first failure. Part-of: #162990
robodoo
pushed a commit
that referenced
this pull request
Apr 29, 2024
Auto retry is mainly useful to avoid the need to rebuild in case of random failure, but once one test failed, this mecanism is useless, creates noises in logs, increase laod by retrying test for no reason, ... This commit should disable this mecanism after the first error. closes #162990 Signed-off-by: Xavier Dollé (xdo) <xdo@odoo.com>
robodoo
pushed a commit
that referenced
this pull request
Apr 29, 2024
Commiting or rollbacking the cursor during test will lead to failure in cascade, because the cursor cannot be rollbacked at the end of the test, and cannot be closed proprely. In some case, it can even provoque failure on following test, maybe because some cleanup are not done proprely. This is also breaking the autoretry mecanism since the cursor cannot be rollbacked, leading to error not related to the first failure. Part-of: #162990
robodoo
pushed a commit
that referenced
this pull request
Apr 29, 2024
Auto retry is mainly useful to avoid the need to rebuild in case of random failure, but once one test failed, this mecanism is useless, creates noises in logs, increase laod by retrying test for no reason, ... This commit should disable this mecanism after the first error. closes #162990 Signed-off-by: Xavier Dollé (xdo) <xdo@odoo.com>
robodoo
pushed a commit
that referenced
this pull request
Apr 29, 2024
Commiting or rollbacking the cursor during test will lead to failure in cascade, because the cursor cannot be rollbacked at the end of the test, and cannot be closed proprely. In some case, it can even provoque failure on following test, maybe because some cleanup are not done proprely. This is also breaking the autoretry mecanism since the cursor cannot be rollbacked, leading to error not related to the first failure. Part-of: #162990
robodoo
pushed a commit
that referenced
this pull request
Apr 29, 2024
Auto retry is mainly useful to avoid the need to rebuild in case of random failure, but once one test failed, this mecanism is useless, creates noises in logs, increase laod by retrying test for no reason, ... This commit should disable this mecanism after the first error. closes #162990 Signed-off-by: Xavier Dollé (xdo) <xdo@odoo.com>
robodoo
pushed a commit
that referenced
this pull request
Apr 29, 2024
Commiting or rollbacking the cursor during test will lead to failure in cascade, because the cursor cannot be rollbacked at the end of the test, and cannot be closed proprely. In some case, it can even provoque failure on following test, maybe because some cleanup are not done proprely. This is also breaking the autoretry mecanism since the cursor cannot be rollbacked, leading to error not related to the first failure. Part-of: #162990
robodoo
pushed a commit
that referenced
this pull request
Apr 29, 2024
Auto retry is mainly useful to avoid the need to rebuild in case of random failure, but once one test failed, this mecanism is useless, creates noises in logs, increase laod by retrying test for no reason, ... This commit should disable this mecanism after the first error. closes #162990 Signed-off-by: Xavier Dollé (xdo) <xdo@odoo.com>
|
@Xavier-Do staging failed: ci/l10n on f5ee98ba946ca334c0fcbe457bf24bf6760c7e2e (view more at https://runbot.odoo.com/runbot/build/61986871) |
Auto retry is mainly useful to avoid the need to rebuild in case of random failure, but once one test failed, this mecanism is useless, creates noises in logs, increase laod by retrying test for no reason, ... This commit should disable this mecanism after the first error.
Commiting or rollbacking the cursor during test will lead to failure in cascade, because the cursor cannot be rollbacked at the end of the test, and cannot be closed proprely. In some case, it can even provoque failure on following test, maybe because some cleanup are not done proprely. This is also breaking the autoretry mecanism since the cursor cannot be rollbacked, leading to error not related to the first failure.
Xavier-Do
force-pushed
the
master-autoretry-imps-xdo
branch
from
b9f7307
to
043e999
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should improve autoretry mecanism overall, and also avoid chain error, even without autoretry, when commiting/rollbacking/closing the cursor opened from a TransactionCase.