[IMP] stock: inventory back2basics #162998
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amoyaux
reviewed
Apr 30, 2024
| @@ -4,7 +4,7 @@ | |||
| <field name="name">stock.move.line.tree</field> | |||
| <field name="model">stock.move.line</field> | |||
| <field name="arch" type="xml"> | |||
| <tree string="Move Lines" create="0" default_order="id desc" action="action_open_reference" type="object"> | |||
| <tree string="Move Lines" create="0" default_order="id desc" action="action_open_reference" type="object" duplicate="false" > | |||
There was a problem hiding this comment.
="0" to be coherent with the other values. Everywhere
temo-odoo
force-pushed
the
master-stock-inventory-b2b-imp-temo
branch
2 times, most recently
from
4ad4fd7
to
5740f1d
Compare
Whenrow
reviewed
May 23, 2024
| @@ -96,6 +96,7 @@ def default_get(self, fields): | |||
| incoming_move_line_ids = fields.One2many('stock.move.line', 'location_dest_id') # used to compute weight | |||
| net_weight = fields.Float('Net Weight', compute="_compute_weight") | |||
| forecast_weight = fields.Float('Forecasted Weight', compute="_compute_weight") | |||
| sequence = fields.Integer(string="Sequence", compute='_compute_location_sequence', store=True) | |||
There was a problem hiding this comment.
make it related instead. Locations without warehouse_id will have sequence = 0
Whenrow
reviewed
May 23, 2024
Whenrow
reviewed
May 23, 2024
| ('location_id', 'in', modified_locations.ids), | ||
| ('state', 'not in', ['done', 'cancel']), | ||
| ('quantity_product_uom', '>', 0), | ||
| ('location_id.usage', '=', 'internal'), |
There was a problem hiding this comment.
There is already a condition on self.ids. Why adding a condition on usage ?
There was a problem hiding this comment.
mybad, yaa no need of that condition.
Whenrow
reviewed
May 23, 2024
| @@ -1070,4 +1070,4 @@ def action_view_all_routes(self): | |||
| } | |||
|
|
|||
| def get_current_warehouses(self): | |||
| return self.env['stock.warehouse'].search_read(fields=['id', 'name', 'code'], order='name') | |||
| return self.env['stock.warehouse'].search_read(fields=['id', 'name', 'code'], order='sequence') | |||
There was a problem hiding this comment.
Leave order empty to use the model order (which is sequence,id so deterministic)
temo-odoo
force-pushed
the
master-stock-inventory-b2b-imp-temo
branch
2 times, most recently
from
90709cf
to
8f812f0
Compare
Whenrow
reviewed
May 23, 2024
Comment on lines
75
to
83
| def _compute_default_location_src_id(self): | ||
| super()._compute_default_location_src_id() | ||
| for picking_type in self.filtered(lambda pt: pt.code == 'dropship'): | ||
| picking_type.default_location_src_id = self.env.ref('stock.stock_location_suppliers').id | ||
|
|
||
| def _compute_default_location_dest_id(self): | ||
| super()._compute_default_location_dest_id() | ||
| for picking_type in self.filtered(lambda pt: pt.code == 'dropship'): | ||
| picking_type.default_location_dest_id = self.env.ref('stock.stock_location_customers').id |
There was a problem hiding this comment.
this is already done from line 49
There was a problem hiding this comment.
Hello @Whenrow
Yaa, you are right i have removed this two methods but this section of code was not present during my development phase this have merged recently.
Thanks.
Whenrow
reviewed
May 23, 2024
| for picking_type in repair_picking_type: | ||
| picking_type.default_location_dest_id = prod_locations.get(picking_type.company_id.id) | ||
| stock_location = picking_type.warehouse_id.lot_stock_id | ||
| picking_type.default_location_dest_id = stock_location.id |
There was a problem hiding this comment.
This is not good, the repair default location were correct already
There was a problem hiding this comment.
when creating an operation type before default destination was Virtual Locations/Production so with this fix i have changed to default WH/Stock as per the spec. in the task in point 5 For repair, the default source & destination to be “WH/Stock”.
cc- @thomasdeleval
Thanks.
temo-odoo
force-pushed
the
master-stock-inventory-b2b-imp-temo
branch
from
8f812f0
to
62f565a
Compare
Whenrow
reviewed
May 28, 2024
| @@ -72,7 +72,6 @@ def _compute_show_picking_type(self): | |||
| if record.code == "dropship": | |||
| record.show_picking_type = True | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
Keep 2 blank lines before classes
kir-odoo
force-pushed
the
master-stock-inventory-b2b-imp-temo
branch
from
62f565a
to
d674419
Compare
In this commit:
====================
- Prevent updating to 'Inventory loss' or 'Scrap Location' of parent/child
location when it has stock.
- Resolve issues where warehouse (WH) sequence fails to update in certain
scenarios, ensuring consistency across Reporting Stock and Replenishment.
- Remove duplicate actions from Inventory menus to streamline user experience
and improve functionality.
- Implement default location assignments based on operation type:
-For internal transfers, manufacturing, and repair, default source and
destination to 'WH/Stock'.
-For Dropship, the default source to 'partner/vendors' and the destination
to 'partners/customers'.
task-3837207
kir-odoo
force-pushed
the
master-stock-inventory-b2b-imp-temo
branch
from
d674419
to
e781ffe
Compare
|
robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
May 29, 2024
In this commit:
====================
- Prevent updating to 'Inventory loss' or 'Scrap Location' of parent/child
location when it has stock.
- Resolve issues where warehouse (WH) sequence fails to update in certain
scenarios, ensuring consistency across Reporting Stock and Replenishment.
- Remove duplicate actions from Inventory menus to streamline user experience
and improve functionality.
- Implement default location assignments based on operation type:
-For internal transfers, manufacturing, and repair, default source and
destination to 'WH/Stock'.
-For Dropship, the default source to 'partner/vendors' and the destination
to 'partners/customers'.
task-3837207
closes #162998
Related: odoo/enterprise#61323
Signed-off-by: William Henrotin (whe) <whe@odoo.com>
visp-odoo
pushed a commit
to odoo-dev/odoo
that referenced
this pull request
May 30, 2024
In this commit:
====================
- Prevent updating to 'Inventory loss' or 'Scrap Location' of parent/child
location when it has stock.
- Resolve issues where warehouse (WH) sequence fails to update in certain
scenarios, ensuring consistency across Reporting Stock and Replenishment.
- Remove duplicate actions from Inventory menus to streamline user experience
and improve functionality.
- Implement default location assignments based on operation type:
-For internal transfers, manufacturing, and repair, default source and
destination to 'WH/Stock'.
-For Dropship, the default source to 'partner/vendors' and the destination
to 'partners/customers'.
task-3837207
closes odoo#162998
Related: odoo/enterprise#61323
Signed-off-by: William Henrotin (whe) <whe@odoo.com>
HANNICHE-Walid
pushed a commit
to odoo-dev/odoo
that referenced
this pull request
May 31, 2024
In this commit:
====================
- Prevent updating to 'Inventory loss' or 'Scrap Location' of parent/child
location when it has stock.
- Resolve issues where warehouse (WH) sequence fails to update in certain
scenarios, ensuring consistency across Reporting Stock and Replenishment.
- Remove duplicate actions from Inventory menus to streamline user experience
and improve functionality.
- Implement default location assignments based on operation type:
-For internal transfers, manufacturing, and repair, default source and
destination to 'WH/Stock'.
-For Dropship, the default source to 'partner/vendors' and the destination
to 'partners/customers'.
task-3837207
closes odoo#162998
Related: odoo/enterprise#61323
Signed-off-by: William Henrotin (whe) <whe@odoo.com>
HANNICHE-Walid
pushed a commit
to odoo-dev/odoo
that referenced
this pull request
May 31, 2024
In this commit:
====================
- Prevent updating to 'Inventory loss' or 'Scrap Location' of parent/child
location when it has stock.
- Resolve issues where warehouse (WH) sequence fails to update in certain
scenarios, ensuring consistency across Reporting Stock and Replenishment.
- Remove duplicate actions from Inventory menus to streamline user experience
and improve functionality.
- Implement default location assignments based on operation type:
-For internal transfers, manufacturing, and repair, default source and
destination to 'WH/Stock'.
-For Dropship, the default source to 'partner/vendors' and the destination
to 'partners/customers'.
task-3837207
closes odoo#162998
Related: odoo/enterprise#61323
Signed-off-by: William Henrotin (whe) <whe@odoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this commit:
task-3837207