Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FW][IMP] make minimum version of Python a variable #163030

Conversation

fw-bot
Copy link
Contributor

@fw-bot fw-bot commented Apr 23, 2024

Make the mininum version of Python a variable so that it can be easily retrieved and used by the code. For example, it could be used to detect when a monkey patch should be removed.

Forward-Port-Of: #156774

@robodoo
Copy link
Contributor

robodoo commented Apr 23, 2024

@fw-bot
Copy link
Contributor Author

fw-bot commented Apr 23, 2024

@oomsveta cherrypicking of pull request #156774 failed.

stdout:

Auto-merging odoo/__init__.py
CONFLICT (content): Merge conflict in odoo/__init__.py

stderr:

18:01:26.131546 git.c:463               trace: built-in: git cherry-pick eb2748782769c4f499af10ac51f65c281120c76f
error: could not apply eb2748782769... [IMP] make minimum version of Python a variable
hint: After resolving the conflicts, mark them with
hint: "git add/rm <pathspec>", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".
----------
status:

Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?).

In the former case, you may want to edit this PR message as well.

⚠️ after resolving this conflict, you will need to merge it via @robodoo.

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

@robodoo robodoo added forwardport This PR was created by @fw-bot conflict There was an error while creating this forward-port PR labels Apr 23, 2024
@C3POdoo C3POdoo added the RD research & development, internal work label Apr 23, 2024
@oomsveta oomsveta force-pushed the saas-16.3-16.0-expose_min_py_version-wil-phEs-fw branch from 04f563d to a855afc Compare April 24, 2024 12:46
Make the mininum version of Python a variable so that it can be easily
retrieved and used by the code. For example, it could be used to detect
when a monkey patch should be removed.

X-original-commit: 41138be
@oomsveta oomsveta force-pushed the saas-16.3-16.0-expose_min_py_version-wil-phEs-fw branch from a855afc to 118415a Compare April 24, 2024 12:47
@C3POdoo C3POdoo requested review from a team, xmo-odoo and ryv-odoo and removed request for a team April 24, 2024 12:55
@oomsveta
Copy link
Contributor

Hello @odoo/rd-security 👋 Could you override ci/security? thanks!
use of sys to retrieve the python version

@xmo-odoo
Copy link
Collaborator

@robodoo override=ci/security

@oomsveta
Copy link
Contributor

robodoo r+

robodoo pushed a commit that referenced this pull request Apr 26, 2024
Make the mininum version of Python a variable so that it can be easily
retrieved and used by the code. For example, it could be used to detect
when a monkey patch should be removed.

closes #163030

X-original-commit: 41138be
Signed-off-by: Louis Wicket (wil) <wil@odoo.com>
@robodoo robodoo closed this Apr 26, 2024
nd-dew pushed a commit to odoo-dev/odoo that referenced this pull request Apr 30, 2024
Make the mininum version of Python a variable so that it can be easily
retrieved and used by the code. For example, it could be used to detect
when a monkey patch should be removed.

closes odoo#163030

X-original-commit: 41138be
Signed-off-by: Louis Wicket (wil) <wil@odoo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conflict There was an error while creating this forward-port PR forwardport This PR was created by @fw-bot RD research & development, internal work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants