Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FW][FIX] account: avoid override of accounts custom reconcile setting #163033

Conversation

fw-bot
Copy link
Contributor

@fw-bot fw-bot commented Apr 23, 2024

In some databases, customers have changed the reconcile value of
an account from its standard False value to True.
This action causes related journal items,
which are partially reconciled, to raise the following
constraint error.
during the upgrade process:

You cannot switch an account to prevent
the reconciliation if some partial reconciliations are still pending

so we delete changes in the reconcile values from the reload
to avoid overriding user customer setting & triggering the
constraint error.

Description of the issue/feature this PR addresses:

Current behavior before PR:

Desired behavior after PR is merged:


I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: #160086

In some databases, customers have changed the `reconcile` value of
an account from its standard `False` value to `True`.
This action causes related journal items,
which are partially reconciled, to raise the following
constraint error.
during the upgrade process:
```
You cannot switch an account to prevent
the reconciliation if some partial reconciliations are still pending
```
so we delete changes in the `reconcile` values from the reload
to avoid overriding user customer setting & triggering the
constraint error.

X-original-commit: 0a4bd1e
@robodoo
Copy link
Contributor

robodoo commented Apr 23, 2024

Pull request status dashboard.

@fw-bot
Copy link
Contributor Author

fw-bot commented Apr 23, 2024

This PR targets saas-17.1 and is part of the forward-port chain. Further PRs will be created up to master.

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

@robodoo robodoo added the forwardport This PR was created by @fw-bot label Apr 23, 2024
@C3POdoo C3POdoo added the RD research & development, internal work label Apr 23, 2024
robodoo pushed a commit that referenced this pull request Apr 24, 2024
In some databases, customers have changed the `reconcile` value of
an account from its standard `False` value to `True`.
This action causes related journal items,
which are partially reconciled, to raise the following
constraint error.
during the upgrade process:
```
You cannot switch an account to prevent
the reconciliation if some partial reconciliations are still pending
```
so we delete changes in the `reconcile` values from the reload
to avoid overriding user customer setting & triggering the
constraint error.

closes #163033

X-original-commit: 0a4bd1e
Signed-off-by: John Laterre (jol) <jol@odoo.com>
@robodoo robodoo closed this Apr 24, 2024
@fw-bot fw-bot deleted the saas-17.1-saas-16.3-avoid-to-update-reconcilation-flag-atp-Xc2y-fw branch May 8, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
forwardport This PR was created by @fw-bot RD research & development, internal work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants