[FW][FIX] web: restore offset in grouped list #163068
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue: Have a grouped list view with several pages, go to the next page, open a group and click on a record to open it in form view. Click on the breadcrumb to go back to the list: the offset is lost, and we're back in page 1. After this commit, the offset is correctly kept. opw~3851390 X-original-commit: 8981338
|
@aab-odoo @SimonGenin this PR targets master and is the last of the forward-port chain containing:
To merge the full chain, use
More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
|
@fw-bot r+ |
robodoo
pushed a commit
that referenced
this pull request
Apr 24, 2024
Issue: Have a grouped list view with several pages, go to the next page, open a group and click on a record to open it in form view. Click on the breadcrumb to go back to the list: the offset is lost, and we're back in page 1. After this commit, the offset is correctly kept. opw~3851390 closes #163068 X-original-commit: 8981338 Signed-off-by: Simon Genin (ges@odoo) <ges@odoo.com> Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
|
@aab-odoo @SimonGenin staging failed: ci/runbot (view more at https://runbot.odoo.com/runbot/build/61747636) |
|
@xmo-odoo Could you check this PR? I don't know what fw-bot is doing... |
|
@aab-odoo I don't see anything to do with the fwbot? It was staged, and the staging failed. If the failure seems legit you fix the pr and re-approve, if it's not you retry the PR. That's normal PR flow. |
|
robodoo retry |
|
@xmo-odoo Ok my bad, I get confused by the linked (failing) build |
|
Yeah it looks weird, might be because of the recent bootstrap updates in runbot /cc @d-fence @Xavier-Do |
robodoo
pushed a commit
that referenced
this pull request
Apr 26, 2024
Issue: Have a grouped list view with several pages, go to the next page, open a group and click on a record to open it in form view. Click on the breadcrumb to go back to the list: the offset is lost, and we're back in page 1. After this commit, the offset is correctly kept. opw~3851390 closes #163068 X-original-commit: 8981338 Signed-off-by: Simon Genin (ges@odoo) <ges@odoo.com> Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
robodoo
pushed a commit
that referenced
this pull request
Apr 26, 2024
Issue: Have a grouped list view with several pages, go to the next page, open a group and click on a record to open it in form view. Click on the breadcrumb to go back to the list: the offset is lost, and we're back in page 1. After this commit, the offset is correctly kept. opw~3851390 closes #163068 X-original-commit: 8981338 Signed-off-by: Simon Genin (ges@odoo) <ges@odoo.com> Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
robodoo
pushed a commit
that referenced
this pull request
Apr 26, 2024
Issue: Have a grouped list view with several pages, go to the next page, open a group and click on a record to open it in form view. Click on the breadcrumb to go back to the list: the offset is lost, and we're back in page 1. After this commit, the offset is correctly kept. opw~3851390 closes #163068 X-original-commit: 8981338 Signed-off-by: Simon Genin (ges@odoo) <ges@odoo.com> Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
|
This one https://runbot.odoo.com/runbot/build/61747636 ? What's the issue? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
Have a grouped list view with several page, go to the next page, open a group and click on a record to open it in form view. Click on the breadcrumb to go back to the list: the offset is lost, and we're back in page 1.
After this commit, the offset is correctly kept.
opw~3851390
Description of the issue/feature this PR addresses:
Current behavior before PR:
Desired behavior after PR is merged:
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
Forward-Port-Of: #162969
Forward-Port-Of: #162844