[FIX] stock: round w/ precision_rounding
#163182
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Versions -------- - 17.0+ Issue ----- `precision_rounding` values were being passed incorrectly as `precision_digits` parameters. Solution -------- Pass them as named `precision_rounding` parameters instead.
lvsz
force-pushed
the
17.0-precision_rounding-sile
branch
from
ea882cb
to
31fc4a5
Compare
|
Good for me, but your ENT PR is for another team to review. I'm not sure if they will like that you changed the formatting 🤷 @robodoo r+ |
This was referenced May 2, 2024
willylohws
pushed a commit
to willylohws/odoo
that referenced
this pull request
May 3, 2024
Versions -------- - 17.0+ Issue ----- `precision_rounding` values were being passed incorrectly as `precision_digits` parameters. Solution -------- Pass them as named `precision_rounding` parameters instead. closes odoo#163182 Related: odoo/enterprise#61387 Signed-off-by: Tiffany Chang (tic) <tic@odoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Versions
Issue
precision_roundingvalues were being passed incorrectly asprecision_digitsparameters.Solution
Pass them as named
precision_roundingparameters instead.Enterprise branch: https://github.com/odoo/enterprise/pull/61387