[FIX] hr: fix traceback when click on employee avatar #163305
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alsh-odoo
force-pushed
the
saas-17.1-sentry-3954475523-valueerror-hr-alsh
branch
3 times, most recently
from
0ca4ddf
to
d43a9a9
Compare
Bertrand2
reviewed
Apr 26, 2024
addons/hr/static/src/components/avatar_card/avatar_card_popover_patch.js
Outdated
Show resolved
Hide resolved
This traceback is occurring when the user tries to click on employee avatar in the employee form view. To reproduce this issue:- 1) Install "Employees" 2) open any employee record 3) click on the avatar of manager or coach 4) A traceback occurs Error:- "ValueError: Invalid field 'employee_ids' on model 'hr.employee'" When the user clicks on the employee avatar in the Employee module a traceback is occurring after [1]. Because the "employee_ids" field is not present in "hr.employee". which leads to the above traceback when the read method[2] triggers with the model as "hr.employee" and fields including "employee_ids" [1] odoo@fdc0693 [2] https://github.com/odoo/odoo/blob/503e9cbf16762cfd753c4427e13228c135db21d5/addons/resource_mail/static/src/components/avatar_card_resource/avatar_card_resource_popover.js#L32-L33 This commit will resolve this issue based on the model in props to concat "employee_id" or "employee_ids" in the fields. sentry-3954475523
alsh-odoo
force-pushed
the
saas-17.1-sentry-3954475523-valueerror-hr-alsh
branch
from
d43a9a9
to
069492d
Compare
|
Hello @Bertrand2 Thanks for reviewing the PR! The requested changes are Done. Please check Thank You 🙂 |
|
robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
Apr 26, 2024
This traceback is occurring when the user tries to click on employee avatar in the employee form view. To reproduce this issue:- 1) Install "Employees" 2) open any employee record 3) click on the avatar of manager or coach 4) A traceback occurs Error:- "ValueError: Invalid field 'employee_ids' on model 'hr.employee'" When the user clicks on the employee avatar in the Employee module a traceback is occurring after [1]. Because the "employee_ids" field is not present in "hr.employee". which leads to the above traceback when the read method[2] triggers with the model as "hr.employee" and fields including "employee_ids" [1] fdc0693 [2] https://github.com/odoo/odoo/blob/503e9cbf16762cfd753c4427e13228c135db21d5/addons/resource_mail/static/src/components/avatar_card_resource/avatar_card_resource_popover.js#L32-L33 This commit will resolve this issue based on the model in props to concat "employee_id" or "employee_ids" in the fields. sentry-3954475523 closes #163305 Related: odoo/enterprise#61444 Signed-off-by: Bertrand Dossogne (bedo) <bedo@odoo.com>
This was referenced Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This traceback occurs when the user clicks on the employee avatar in the employee form view.
To reproduce this issue:-
EmployeesavatarofmanagerorcoachError:-
When the user clicks on the
employee avatarin theEmployeemodule a traceback occurs after[1].Because the
employee_idsfield is not present inhr.employee.which leads to the above traceback when the
readmethod[2]triggerswith the model as
hr.employeeand fields includingemployee_ids[1]
fdc0693
[2]
odoo/addons/resource_mail/static/src/components/avatar_card_resource/avatar_card_resource_popover.js
Lines 32 to 33 in 503e9cb
This commit will resolve this issue based on the model in
propsto concat
employee_idoremployee_idsin the fields.Related Enterprise PR:- https://github.com/odoo/enterprise/pull/61444
sentry-3954475523