-
Notifications
You must be signed in to change notification settings - Fork 23.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IMP] web, board, spreadsheet: add app icon & normalize the UI app icons implementation #163328
base: master
Are you sure you want to change the base?
[IMP] web, board, spreadsheet: add app icon & normalize the UI app icons implementation #163328
Conversation
Hello @stefanorigano 👋 |
0ff6574
to
a3cb878
Compare
Taking the occasion, but going a bit off-topic (sorry for that), do you have any general guidelines about the creation of the new milk app icons (color scheme, main layout, etc)? |
Hello @pedrobaeza, |
Thanks for answering, Brieuc. I'm talking on behalf of OCA, as we need to design totally new icons for new apps. Would you ask if that guides can be released for the general public? That way, we would keep consistency between them, as they are all shown in enterprise app chooser and module list. Example: |
For now I don't know if there are any plans to publish a general guideline related to the new app icons. cc. @stefanorigano |
a3cb878
to
fd5d9aa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hei @Brieuc-brd , thanks so much for your work (and patience) 🙂
Here some remarks for you, thanks again!
cc87f7b
to
b7e8435
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @Brieuc-brd , thanks!
Like the enterprise PR, let's update the pr description and then we're ready to go 👍
Also, nitpicking but we could use the actual module name (board
), rather than having it replaced by *
in [IMP] web, *: [...]
... it's just a few characters difference at the end.
Thanks!
b7e8435
to
6f6082e
Compare
Thanks @stefanorigano 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @Brieuc-brd 👍
Hello @odoo/rd-spreadsheet 👋 |
Prior to this commit, the style related to the UI app icons was defined in each module, which creates duplicated code. To avoid that, this commit normalizes the implementation of these icons. Only one class need to be defined: - `o_ui_app_icon` should be defined on the svg. task-3884720
This commit introduces an app icon for `spreadsheet`. task-3884720
6f6082e
to
f44e93b
Compare
spreadsheet
: Add app iconThis PR introduces an app icon for
spreadsheet
.Normalize the UI app icons implementation
Prior to this PR, the style related to the UI app icons was defined in each module, which creates duplicated code.
To avoid that, this commit normalizes the implementation of these icons.
Only one class need to be defined:
o_ui_app_icon
should be defined on the svg.task-3884720
Requires:
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr