[FIX] website: allow proper customization of navbar expand classes #163337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit [1] introduced a template for the website navbar with a configurable `_navbar_expand_class` variable... but the variable was acting as a boolean by mistake: if set, it would not set up any class and if not set, it would set the default navbar-expand-lg class. Meanwhile, a new `_navbar_classes` variable was introduced allowing customization anyway but it is still worth fixing for consistency. Also, commit [2] and [3] actually used the variable giving it the *string* "None"... which is just inconsistent and confusing, despite working as intended given the original implementation mistake. [1]: odoo@6854ff8 [2]: odoo@2dc3b28 [3]: odoo@bc13176 Thanks to imanie383 <manuel@vauxoo.com> Closes odoo#126489
qsm-odoo
commented
Apr 25, 2024
robodoo
pushed a commit
that referenced
this pull request
Apr 25, 2024
Commit [1] introduced a template for the website navbar with a configurable `_navbar_expand_class` variable... but the variable was acting as a boolean by mistake: if set, it would not set up any class and if not set, it would set the default navbar-expand-lg class. Meanwhile, a new `_navbar_classes` variable was introduced allowing customization anyway but it is still worth fixing for consistency. Also, commit [2] and [3] actually used the variable giving it the *string* "None"... which is just inconsistent and confusing, despite working as intended given the original implementation mistake. [1]: 6854ff8 [2]: 2dc3b28 [3]: bc13176 Thanks to imanie383 <manuel@vauxoo.com> Closes #126489 closes #163337 Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
zel-odoo
pushed a commit
to odoo-dev/odoo
that referenced
this pull request
Apr 29, 2024
Commit [1] introduced a template for the website navbar with a configurable `_navbar_expand_class` variable... but the variable was acting as a boolean by mistake: if set, it would not set up any class and if not set, it would set the default navbar-expand-lg class. Meanwhile, a new `_navbar_classes` variable was introduced allowing customization anyway but it is still worth fixing for consistency. Also, commit [2] and [3] actually used the variable giving it the *string* "None"... which is just inconsistent and confusing, despite working as intended given the original implementation mistake. [1]: odoo@6854ff8 [2]: odoo@2dc3b28 [3]: odoo@bc13176 Thanks to imanie383 <manuel@vauxoo.com> Closes odoo#126489 closes odoo#163337 Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 1 introduced a template for the website navbar with a configurable
_navbar_expand_classvariable... but the variable was acting as a boolean by mistake: if set, it would not set up any class and if not set, it would set the default navbar-expand-lg class.Meanwhile, a new
_navbar_classesvariable was introduced allowing customization anyway but it is still worth fixing for consistency. Also, commit 2 and 3 actually used the variable giving it the string "None"... which is just inconsistent and confusing, despite working as intended given the original implementation mistake.Thanks to imanie383 manuel@vauxoo.com
Closes #126489