[FIX] l10n_ar_pos: no traceback on creating partner pos when argentina localization #163385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a localization Steps to reproduce: 1. Install l10n_ar_pos. 2. Make sure we are in the Argentinian company. 3. Open PoS and create a new session. 4. When inside, try to create a new partner from here. The issue is that, since the changes where we retrieve the partner from the props, we might have cases where we don't have a partner since this field is defined as optional in our point_of_sale PartnerList, from we retrieve the props from. opw-3872968
C3POdoo
requested review from
a team and
epictete
and removed request for
a team
epictete
approved these changes
Apr 26, 2024
robodoo
pushed a commit
that referenced
this pull request
Apr 26, 2024
…a localization Steps to reproduce: 1. Install l10n_ar_pos. 2. Make sure we are in the Argentinian company. 3. Open PoS and create a new session. 4. When inside, try to create a new partner from here. The issue is that, since the changes where we retrieve the partner from the props, we might have cases where we don't have a partner since this field is defined as optional in our point_of_sale PartnerList, from we retrieve the props from. opw-3872968 closes #163385 Signed-off-by: John Laterre (jol) <jol@odoo.com>
This was referenced Apr 26, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps to reproduce:
The issue is that, since the changes where we retrieve the partner from the props, we might have cases where we don't have a partner since this field is defined as optional in our point_of_sale PartnerList, from we retrieve the props from.
opw-3872968