[FW][FIX] account_edi: allow users to read account.edi.format/documnet #163427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Steps to Reproduce ------------------ 1. Install `sale_management` and `account_edi`. 2. Create a user with admin access in sales but no rights in accounting. 3. Log in as the new user. 4. Navigate to a Sales Order that has been invoiced and attempt to view its invoice via the 'Invoices' stat button. Expected Behavior: The user should be able to view the invoice. Actual Behavior: An access error is encountered when attempting to view the invoice. Cause ----- The access error arises due to restricted permissions for `account.edi.format` and `account.edi.document`. Prior to commit 604a47e, all users had access to these models. However, this commit restricted access solely to users with the `account.group_account_readonly` role, as part of a broader security enhancement to minimize unnecessary access by portal users. opw-3858685 X-original-commit: 3be00fa
|
This PR targets saas-17.1 and is part of the forward-port chain. Further PRs will be created up to master. More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
robodoo
pushed a commit
that referenced
this pull request
Apr 25, 2024
Steps to Reproduce ------------------ 1. Install `sale_management` and `account_edi`. 2. Create a user with admin access in sales but no rights in accounting. 3. Log in as the new user. 4. Navigate to a Sales Order that has been invoiced and attempt to view its invoice via the 'Invoices' stat button. Expected Behavior: The user should be able to view the invoice. Actual Behavior: An access error is encountered when attempting to view the invoice. Cause ----- The access error arises due to restricted permissions for `account.edi.format` and `account.edi.document`. Prior to commit 604a47e, all users had access to these models. However, this commit restricted access solely to users with the `account.group_account_readonly` role, as part of a broader security enhancement to minimize unnecessary access by portal users. opw-3858685 closes #163427 X-original-commit: 3be00fa Signed-off-by: Brice Bartoletti (bib) <bib@odoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps to Reproduce
sale_managementandaccount_edi.Expected Behavior: The user should be able to view the invoice.
Actual Behavior: An access error is encountered when attempting to view the invoice.
Cause
The access error arises due to restricted permissions for
account.edi.formatandaccount.edi.document. Prior to commit 604a47e, all users had access to these models. However, this commit restricted access solely to users with theaccount.group_account_readonlyrole, as part of a broader security enhancement to minimize unnecessary access by portal users.opw-3858685
Forward-Port-Of: #163329