Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FW][FIX] base: deal with deprecated config options #163436

Conversation

fw-bot
Copy link
Contributor

@fw-bot fw-bot commented Apr 25, 2024

Some options have been renammed a long time ago but there was no mechanism to warn the user should those option be still present in its configuration file.

Odoo versions up to Odoo 14 (excluded) used osv_memory_time_limit and geoip_database in their configuration, those two options have been renamed to transient_age_limit and geoip_city_db in 14.0 ab4000f and saas-16.1 c59750d but no deprecation warning / automatic failover were provided.

Description of the issue/feature this PR addresses:

Current behavior before PR:

Desired behavior after PR is merged:


I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: #163193

Some options have been renammed a long time ago but there was no
mechanism to warn the user should those option be still present in its
configuration file.

Odoo versions up to Odoo 14 (excluded) used `osv_memory_time_limit` and
`geoip_database` in their configuration, those two options have been
renamed to `transient_age_limit` and `geoip_city_db` in 14.0 ab4000f and
saas-16.1 c59750d but no deprecation warning / automatic failover
were provided.

X-original-commit: 7a074c9
@robodoo
Copy link
Contributor

robodoo commented Apr 25, 2024

@fw-bot
Copy link
Contributor Author

fw-bot commented Apr 25, 2024

This PR targets saas-17.1 and is part of the forward-port chain. Further PRs will be created up to master.

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

@robodoo robodoo added the forwardport This PR was created by @fw-bot label Apr 25, 2024
@C3POdoo C3POdoo added the RD research & development, internal work label Apr 25, 2024
robodoo pushed a commit that referenced this pull request Apr 26, 2024
Some options have been renammed a long time ago but there was no
mechanism to warn the user should those option be still present in its
configuration file.

Odoo versions up to Odoo 14 (excluded) used `osv_memory_time_limit` and
`geoip_database` in their configuration, those two options have been
renamed to `transient_age_limit` and `geoip_city_db` in 14.0 ab4000f and
saas-16.1 c59750d but no deprecation warning / automatic failover
were provided.

closes #163436

X-original-commit: 7a074c9
Signed-off-by: Julien Castiaux (juc) <juc@odoo.com>
@robodoo robodoo closed this Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
forwardport This PR was created by @fw-bot RD research & development, internal work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants