Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FW][FIX] website_event_sale: ensure sale_last_order_id is set in session #163591

Conversation

fw-bot
Copy link
Contributor

@fw-bot fw-bot commented Apr 26, 2024

This commit fixes an issue where the sale_last_order_id was not being set in the session when the extra info step was added to the checkout process. This caused an error during the validation of event payment in shop_payment_validate.

Steps to reproduce the issue:

  1. Install website_event_sale and set up a payment provider.
  2. Add the extra info step to the checkout in the website.
  3. Register for a paid event from the website.
  4. Proceed to pay the order, which would previously result in an error.

opw-3864873


I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: #163376
Forward-Port-Of: #162657

This commit fixes an issue where the `sale_last_order_id` was not being
set in the session when the extra info step was added to the checkout
process. This caused an error during the validation of event payment in
`shop_payment_validate`.

Steps to reproduce the issue:
1. Install `website_event_sale` and set up a payment provider.
2. Add the extra info step to the checkout in the website.
3. Register for a paid event from the website.
4. Proceed to pay the order, which would previously result in an error.

opw-3864873

X-original-commit: 85584c8
@robodoo robodoo added the forwardport This PR was created by @fw-bot label Apr 26, 2024
@robodoo
Copy link
Contributor

robodoo commented Apr 26, 2024

@fw-bot
Copy link
Contributor Author

fw-bot commented Apr 26, 2024

@pedrambiria @jeh-odoo this PR targets master and is the last of the forward-port chain.

To merge the full chain, use

@fw-bot r+

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

@C3POdoo C3POdoo added the OE the report is linked to a support ticket (opw-...) label Apr 26, 2024
@jeh-odoo
Copy link
Contributor

@fw-bot r+

robodoo pushed a commit that referenced this pull request Apr 26, 2024
This commit fixes an issue where the `sale_last_order_id` was not being
set in the session when the extra info step was added to the checkout
process. This caused an error during the validation of event payment in
`shop_payment_validate`.

Steps to reproduce the issue:
1. Install `website_event_sale` and set up a payment provider.
2. Add the extra info step to the checkout in the website.
3. Register for a paid event from the website.
4. Proceed to pay the order, which would previously result in an error.

opw-3864873

closes #163591

X-original-commit: 85584c8
Signed-off-by: Pedram Bi Ria (pebr) <pebr@odoo.com>
Signed-off-by: Jérémy Hennecart (jeh) <jeh@odoo.com>
robodoo pushed a commit that referenced this pull request Apr 26, 2024
This commit fixes an issue where the `sale_last_order_id` was not being
set in the session when the extra info step was added to the checkout
process. This caused an error during the validation of event payment in
`shop_payment_validate`.

Steps to reproduce the issue:
1. Install `website_event_sale` and set up a payment provider.
2. Add the extra info step to the checkout in the website.
3. Register for a paid event from the website.
4. Proceed to pay the order, which would previously result in an error.

opw-3864873

closes #163591

X-original-commit: 85584c8
Signed-off-by: Pedram Bi Ria (pebr) <pebr@odoo.com>
Signed-off-by: Jérémy Hennecart (jeh) <jeh@odoo.com>
@robodoo robodoo closed this Apr 26, 2024
@robodoo robodoo added the 17.3 label Apr 26, 2024
MohammedBasioni pushed a commit to odoo-dev/odoo that referenced this pull request May 6, 2024
This commit fixes an issue where the `sale_last_order_id` was not being
set in the session when the extra info step was added to the checkout
process. This caused an error during the validation of event payment in
`shop_payment_validate`.

Steps to reproduce the issue:
1. Install `website_event_sale` and set up a payment provider.
2. Add the extra info step to the checkout in the website.
3. Register for a paid event from the website.
4. Proceed to pay the order, which would previously result in an error.

opw-3864873

closes odoo#163591

X-original-commit: 85584c8
Signed-off-by: Pedram Bi Ria (pebr) <pebr@odoo.com>
Signed-off-by: Jérémy Hennecart (jeh) <jeh@odoo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
17.3 forwardport This PR was created by @fw-bot OE the report is linked to a support ticket (opw-...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants