Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FW][IMP] account: added bank account on customer invoice #163624

Conversation

fw-bot
Copy link
Contributor

@fw-bot fw-bot commented Apr 26, 2024

On a customer invoice, the sentence
"Please use the following communication for your payment : +++000/0000/10205+++"
was changed to
"Please use the following communication for your payment : +++000/0000/10205+++ on this account : BE81 3101 2528 8724"

Customer invoices only had payment reference.
Bank account (iban) was also needed on the invoice.

task-3794432


I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: #157503

@robodoo
Copy link
Contributor

robodoo commented Apr 26, 2024

@fw-bot
Copy link
Contributor Author

fw-bot commented Apr 26, 2024

@hsal-odoo @qdp-odoo cherrypicking of pull request #157503 failed.

stdout:

Auto-merging addons/account/i18n/account.pot
CONFLICT (content): Merge conflict in addons/account/i18n/account.pot
Auto-merging addons/account/views/report_invoice.xml
CONFLICT (content): Merge conflict in addons/account/views/report_invoice.xml

stderr:

19:57:38.911907 git.c:463               trace: built-in: git cherry-pick 98368c363bf4cb9604948a52196c6a61985dc34d
error: could not apply 98368c363bf4... [IMP] account: added bank account on customer invoice
hint: After resolving the conflicts, mark them with
hint: "git add/rm <pathspec>", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".
----------
status:

Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?).

In the former case, you may want to edit this PR message as well.

⚠️ after resolving this conflict, you will need to merge it via @robodoo.

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

@C3POdoo C3POdoo added the RD research & development, internal work label Apr 26, 2024
@robodoo robodoo added forwardport This PR was created by @fw-bot conflict There was an error while creating this forward-port PR labels Apr 26, 2024
@hsal-odoo hsal-odoo force-pushed the 16.0-15.0-account-invoice_bank_account-hsal-mVWc-fw branch from 538d716 to ef3292f Compare April 26, 2024 21:16
On a customer invoice, the sentence
"Please use the following communication for your payment : +++000/0000/10205+++"
was changed to
"Please use the following communication for your payment : +++000/0000/10205+++ on this account : BE81 3101 2528 8724"

Customer invoices only had payment reference.
Bank account (iban) was also needed on the invoice.

task-3794432

X-original-commit: 9a35ee7
@hsal-odoo hsal-odoo force-pushed the 16.0-15.0-account-invoice_bank_account-hsal-mVWc-fw branch from ef3292f to e99da9f Compare April 26, 2024 21:20
@hsal-odoo
Copy link
Contributor

@robodoo r+

robodoo pushed a commit that referenced this pull request Apr 26, 2024
On a customer invoice, the sentence
"Please use the following communication for your payment : +++000/0000/10205+++"
was changed to
"Please use the following communication for your payment : +++000/0000/10205+++ on this account : BE81 3101 2528 8724"

Customer invoices only had payment reference.
Bank account (iban) was also needed on the invoice.

task-3794432

closes #163624

X-original-commit: 9a35ee7
Signed-off-by: Quentin De Paoli <qdp@odoo.com>
Signed-off-by: Hesham Saleh (hsal) <hsal@odoo.com>
@robodoo robodoo closed this Apr 27, 2024
MohammedBasioni pushed a commit to odoo-dev/odoo that referenced this pull request Apr 29, 2024
On a customer invoice, the sentence
"Please use the following communication for your payment : +++000/0000/10205+++"
was changed to
"Please use the following communication for your payment : +++000/0000/10205+++ on this account : BE81 3101 2528 8724"

Customer invoices only had payment reference.
Bank account (iban) was also needed on the invoice.

task-3794432

closes odoo#163624

X-original-commit: 9a35ee7
Signed-off-by: Quentin De Paoli <qdp@odoo.com>
Signed-off-by: Hesham Saleh (hsal) <hsal@odoo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conflict There was an error while creating this forward-port PR forwardport This PR was created by @fw-bot RD research & development, internal work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants