[FW][FIX] website: neutralize recursion when determining current website #163625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bso-odoo @rdeodoo cherrypicking of pull request #162892 failed. stdout: stderr: Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?). In the former case, you may want to edit this PR message as well. More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
robodoo
added
forwardport
If an `ir.rule` about websites involves obtaining the rule's evaluation context, an infinite recursion happens right after login: - the `_login` tries to create a `res.users.log` record which needs to resolve the ACL - to do this `_eval_context()` is called on `ir.rule`, which in its `website` module override uses `get_current_website()` - in turn, this calls `website`'s `_get_current_website_id()` which is not cached yet - this involves a `search()` on `website` which needs to resolve the ACL - to do this `_eval_context()` is again called on `ir.rule`, causing the loop This commit prevent this infinite recursion by disabling the ACL check when determining the current website id in `get_current_website()`, similarly to what is done in [1] in future versions. Steps to reproduce: - Create a rule about `website` with `domain_force` set to `[(1, '=', 1)]`. - Log in from an incognito browser. => Error 500 because of an infinite recursion. [1]: odoo@c68fa61#diff-5e92e473fa4d3da6db7ef727fb217dad51ef6c2383913edca73fe040a23e82c2R978 task-3884701 opw-3603541 X-original-commit: c4a2f75
bso-odoo
force-pushed
the
16.0-15.0-recursive_current_website-bso-65wo-fw
branch
from
abcd196
to
e86fecc
Compare
|
@robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
Apr 30, 2024
If an `ir.rule` about websites involves obtaining the rule's evaluation context, an infinite recursion happens right after login: - the `_login` tries to create a `res.users.log` record which needs to resolve the ACL - to do this `_eval_context()` is called on `ir.rule`, which in its `website` module override uses `get_current_website()` - in turn, this calls `website`'s `_get_current_website_id()` which is not cached yet - this involves a `search()` on `website` which needs to resolve the ACL - to do this `_eval_context()` is again called on `ir.rule`, causing the loop This commit prevent this infinite recursion by disabling the ACL check when determining the current website id in `get_current_website()`, similarly to what is done in [1] in future versions. Steps to reproduce: - Create a rule about `website` with `domain_force` set to `[(1, '=', 1)]`. - Log in from an incognito browser. => Error 500 because of an infinite recursion. [1]: c68fa61#diff-5e92e473fa4d3da6db7ef727fb217dad51ef6c2383913edca73fe040a23e82c2R978 task-3884701 opw-3603541 closes #163625 X-original-commit: c4a2f75 Signed-off-by: Romain Derie (rde) <rde@odoo.com> Signed-off-by: Benoit Socias (bso) <bso@odoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an
ir.ruleabout websites involves obtaining the rule's evaluationcontext, an infinite recursion happens right after login:
_logintries to create ares.users.logrecord which needs toresolve the ACL
_eval_context()is called onir.rule, which in itswebsitemodule override usesget_current_website()website's_get_current_website_id()which isnot cached yet
search()onwebsitewhich needs to resolve the ACL_eval_context()is again called onir.rule, causing theloop
This commit prevent this infinite recursion by disabling the ACL check
when determining the current website id in
get_current_website(),similarly to what is done in 1 in future versions.
Steps to reproduce:
websitewithdomain_forceset to[(1, '=', 1)].=> Error 500 because of an infinite recursion.
task-3884701
opw-3603541
Forward-Port-Of: #162892