[FIX] website: make facebook snippet dynamically responsive #163739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
divy-odoo
reviewed
Apr 30, 2024
paru-odoo
force-pushed
the
16.0-fix-facebook-dynamic-content-not-responsive-paru
branch
from
410601c
to
5b9ab98
Compare
msh-odoo
force-pushed
the
16.0-fix-facebook-dynamic-content-not-responsive-paru
branch
from
54fbd28
to
9a53419
Compare
Step to reproduce 1. Drop inner content facebook (dynamic content) anywhere 2. Go to mobile view 3. Try to scroll horizontally. As you can see, facebook iframe is overflowing Before v16, the mechanism for mobile view was different. The switch between mobile and desktop views caused snippets/pages to be rerendered because a new dialog for the mobile was opened every time. Starting from version 16, we have removed the dialog and introduced a mobile frame. As a result, the rendering now occurs only when the start function is called. Consequently, the params width does not change when we switch to mobile view. After this commit, the snippet will be rerender every time when the window resizes, ensuring that the width adjustment is responsive. This enhancement also allows parameters to be provided at the time of rendering. Task-2736174
msh-odoo
force-pushed
the
16.0-fix-facebook-dynamic-content-not-responsive-paru
branch
from
9a53419
to
6fc0600
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix an issue with the Facebook snippet not being dynamically responsive for mobile views.
Steps to reproduce
As you can see, facebook iframe is overflowing
Before v16, the mechanism for mobile view was different. The switch between mobile and desktop views caused snippets/pages to be re-render because a new dialog for mobile was opened every time. Starting from version 16, we have removed the dialog and introduced a mobile frame. As a result, the rendering now occurs only when the start function is called. Consequently, the params width does not change when we switch to mobile view.
After this PR, the snippet will be re-render every time the window resizes, ensuring that the width adjustment is responsive. This enhancement also allows parameters to be provided at the time of rendering.
Task-2736174