Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] website_*: add color field in tags of Blog, Forum #163763

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

panv-odoo
Copy link

@panv-odoo panv-odoo commented Apr 29, 2024

*: blog, forum

Specification:

Prior to this commit, tags were displayed in a standard format, lacking visual appeal.

Changes introduced:

  1. Enhanced the blog and forum tag functionality by introducing a new color field in the blog's and forum's tags model.
  2. Renamed the forum tag section to 'Forum Tags' for clarity.

This implementation allows users to customize tag appearance, improving visual appeal and usability across the platform.

Change in UI are as follow:

website_Blog

  1. Blog Tag Form View
    image

  2. Blogs Page:
    image

  3. Blog Detail Page:
    image

website_forum:

  1. Forum Tag Tree View:
    image

  2. Forum Page:
    image

  3. Forum Detail Page:
    image

task-3890442

@robodoo
Copy link
Contributor

robodoo commented Apr 29, 2024

Pull request status dashboard.

@C3POdoo C3POdoo added the RD research & development, internal work label Apr 29, 2024
@panv-odoo panv-odoo force-pushed the master-imp-add-color-field-in-blog-and-forum-tags-panv branch 2 times, most recently from 5a0ab84 to 203e1d4 Compare April 30, 2024 09:22
@panv-odoo panv-odoo force-pushed the master-imp-add-color-field-in-blog-and-forum-tags-panv branch 2 times, most recently from 2a23b33 to 6c6c307 Compare May 15, 2024 10:00
@panv-odoo panv-odoo force-pushed the master-imp-add-color-field-in-blog-and-forum-tags-panv branch 4 times, most recently from d08c68a to 0c18881 Compare May 20, 2024 08:49
@panv-odoo panv-odoo force-pushed the master-imp-add-color-field-in-blog-and-forum-tags-panv branch 4 times, most recently from 42e1d87 to 6900f4b Compare May 28, 2024 10:36
@msh-odoo msh-odoo force-pushed the master-imp-add-color-field-in-blog-and-forum-tags-panv branch from fa1836c to cdb5373 Compare June 7, 2024 07:16
Copy link
Contributor

@SergeBayet SergeBayet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, good job and thanks for this PR

A typo in your commit message.

  • introduced instead of "introducted"

Here my review, just a few nipticks.

@@ -142,6 +142,7 @@ class BlogTag(models.Model):

name = fields.Char('Name', required=True, translate=True)
category_id = fields.Many2one('blog.tag.category', 'Category', index=True)
color = fields.Integer('Color Index')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably better and more user-friendly to use simply 'Color' than Color Index

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SergeBayet As it is Integer field and it is not going to store color Hex code, we are going to store the color index which is predefined so we have used Color Index like we used everywhere in other modules.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@msh-odoo Indeed. So be it :)

@@ -16,6 +16,7 @@ class Tags(models.Model):
]

name = fields.Char('Name', required=True)
color = fields.Integer('Color Index')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.

*: blog,forum

Specification:

Prior to this commit, tags were displayed in a standard format, lacking
visual appeal.

Changes introduced:

1. Enhanced the blog and forum tag functionality by introducing a new
color field in the blog's and  forum's tags model.
2. Renamed the forum tag section to 'Forum Tags' for clarity.

This implementation allows users  to customize tag appearance, improving
visual appeal and usability across the platform.

task-3890442
@panv-odoo panv-odoo force-pushed the master-imp-add-color-field-in-blog-and-forum-tags-panv branch from cdb5373 to 0eefb98 Compare June 13, 2024 10:41
@panv-odoo
Copy link
Author

Hello,
I have made the requested changes in the commit message.
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RD research & development, internal work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants