-
Notifications
You must be signed in to change notification settings - Fork 23.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IMP] website_*: add color field in tags of Blog, Forum #163763
base: master
Are you sure you want to change the base?
[IMP] website_*: add color field in tags of Blog, Forum #163763
Conversation
5a0ab84
to
203e1d4
Compare
2a23b33
to
6c6c307
Compare
d08c68a
to
0c18881
Compare
42e1d87
to
6900f4b
Compare
fa1836c
to
cdb5373
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, good job and thanks for this PR
A typo in your commit message.
- introduced instead of "introducted"
Here my review, just a few nipticks.
@@ -142,6 +142,7 @@ class BlogTag(models.Model): | |||
|
|||
name = fields.Char('Name', required=True, translate=True) | |||
category_id = fields.Many2one('blog.tag.category', 'Category', index=True) | |||
color = fields.Integer('Color Index') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably better and more user-friendly to use simply 'Color' than Color Index
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@SergeBayet As it is Integer field and it is not going to store color Hex code, we are going to store the color index which is predefined so we have used Color Index like we used everywhere in other modules.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@msh-odoo Indeed. So be it :)
@@ -16,6 +16,7 @@ class Tags(models.Model): | |||
] | |||
|
|||
name = fields.Char('Name', required=True) | |||
color = fields.Integer('Color Index') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here.
*: blog,forum Specification: Prior to this commit, tags were displayed in a standard format, lacking visual appeal. Changes introduced: 1. Enhanced the blog and forum tag functionality by introducing a new color field in the blog's and forum's tags model. 2. Renamed the forum tag section to 'Forum Tags' for clarity. This implementation allows users to customize tag appearance, improving visual appeal and usability across the platform. task-3890442
cdb5373
to
0eefb98
Compare
Hello, |
*: blog, forum
Specification:
Prior to this commit, tags were displayed in a standard format, lacking visual appeal.
Changes introduced:
This implementation allows users to customize tag appearance, improving visual appeal and usability across the platform.
Change in UI are as follow:
website_Blog
Blog Tag Form View
Blogs Page:
Blog Detail Page:
website_forum:
Forum Tag Tree View:
Forum Page:
Forum Detail Page:
task-3890442