[FIX] sale_stock: fix singleton error on invoice line with multiple sales line #163766

amay-odoo · 2024-04-29T10:14:39Z

The issue:
When creating an invoice from multiple sale orders, each invoice line is going to be linked to the appropriate sale order line from each sale order, which will cause a singleton traceback when trying to access the is_downpayment field

Expected behavior:
to confirm the invoice

Current Behavior:
Singleton traceback

opw-3878327

…ales line The issue: When creating an invoice from multiple sale orders, each invoice line is going to be linked to the appropriate sale order line from each sale order, which will cause a singleton traceback when trying to access the is_downpayment field Expected behavior: to confirm the invoice Current Behavior: Singleton traceback opw-3878327

robodoo · 2024-04-29T10:15:05Z

.

amay-odoo · 2024-05-02T10:56:00Z

Hello @odoo/rd-logistics , Could someone please have a look at this PR? Thanks

Sehnde

Hello,
As discussed in DM:
The code is sound but the issue doesn't appear reproducible as each sale line creates its own invoice line, based on this here:

odoo/addons/sale/models/sale_order_line.py

Lines 1126 to 1151 in 71227db

    
               def _prepare_invoice_line(self, **optional_values): 
        
                   """Prepare the values to create the new invoice line for a sales order line. 
        
                   :param optional_values: any parameter that should be added to the returned invoice line 
        
                   :rtype: dict 
        
                   """ 
        
                   self.ensure_one() 
        
                   res = { 
        
                       'display_type': self.display_type or 'product', 
        
                       'sequence': self.sequence, 
        
                       'name': self.name, 
        
                       'product_id': self.product_id.id, 
        
                       'product_uom_id': self.product_uom.id, 
        
                       'quantity': self.qty_to_invoice, 
        
                       'discount': self.discount, 
        
                       'price_unit': self.price_unit, 
        
                       'tax_ids': [Command.set(self.tax_id.ids)], 
        
                       'sale_line_ids': [Command.link(self.id)], 
        
                       'is_downpayment': self.is_downpayment, 
        
                   } 
        
                   self._set_analytic_distribution(res, **optional_values) 
        
                   if optional_values: 
        
                       res.update(optional_values) 
        
                   if self.display_type: 
        
                       res['account_id'] = False 
        
                   return res

If you manage to reproduce it on a fresh DB/runbot, please update your commit and PR message with the steps to take.

amoyaux · 2024-05-06T15:37:45Z

@Sehnde You tried to do a return / credit note / return of return. Invoice again?

Sehnde · 2024-05-07T07:02:26Z

@amoyaux just did, here are my steps:

create 2 SOs, each SO has 3 SO lines for 1 unit of product A at $1/u, total $3 per SO
add a downpayment of $1 on each SO, validate
select both SOs on list view, create a single invoice for both, validate
do a full/partial return on both SOs (tried both)
do a full/partial credit note on the main invoice
do a return of return for everything that was initially returned (note: in v16 a return of return still indicate 'Receive From [partner]' even if the stock move are correctly from the stock to partner location/customer)
re-select both SOs to create a single invoice, validate
no bug

This is expected because the number of SO lines does not vary and each SO line creates a single invoice line at confirmation. Even if the total amount of invoice lines is higher due to multiple invoices, the filtered will only go through one at a time and there's only 1 SO line linked.
However, seeing as the field is a Many2Many linked to invoice_lines, we could still validate this PR to be logical. It should have been a Many2one based on how it's used, or the behavior was changed in stable and it was too late to switch the field type.

Sehnde

even if there's no bug, it is safer to use any + mapped with a Many2Many field

amoyaux · 2024-05-28T09:24:55Z

robodoo r+

…ales line The issue: When creating an invoice from multiple sale orders, each invoice line is going to be linked to the appropriate sale order line from each sale order, which will cause a singleton traceback when trying to access the is_downpayment field Expected behavior: to confirm the invoice Current Behavior: Singleton traceback opw-3878327 closes #163766 Signed-off-by: Arnold Moyaux (arm) <arm@odoo.com>

fw-bot · 2024-06-01T05:54:09Z