[FW] 16.0 stock sn perf arm #163799
Open
[FW] 16.0 stock sn perf arm #163799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use a set instead of recordset. Removing an item from the recordset is O(n) and it's done at each loop operation resulting in a O(n²) On top of it. The variable is call in a depends_context of a compute. Extract the part of the computation that depends of it in another private function and call it when needed. X-original-commit: 95730a6
Currently it does a search for each lot name. It could be process only once to find the existing ones. X-original-commit: 2c1d8b8
|
This PR targets saas-17.1 and is part of the forward-port chain. Further PRs will be created up to master. More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this PR is to be able to process a lot of serial numbers at once. In receipt and deliveries
In the current situation, the number of serial already in stock has an impact on the perf (due to
update_available_quantitythat do a_gatheron current stock). All the metrics below are made with 50 000 SN already in stockBefore (in seconds):
After:
By operations/ receipts (for 5000):
By operations/ deliveries (for 5000):
The main issues:
_action_assignuse strict=False in_gather(mts case). It means a child_of operator is in the domain, and it will perform an extra query anywaystock.move.linebystock.move.lineon 30 000, half of the time is spent to find them.After some testing. The quant_cache could contain too many items than needed by the current operation. Example receive 1 serial number (that will not have an existing quant) will use a quant_cache with all the serial number of the products. As a result, the group by will be super slow. Allow to add an extra domain, to limit the cache size. /!\ could be dangerous if it filter out too much
Forward-Port-Of: #158229
Forward-Port-Of: #146494