Commits on Apr 29, 2024

1. [FIX] calendar: no duplicated alarm in daily recurrences …

   Before this commit, alarms were always being set up when there was no 'next_date' specified, creating an undeterministic behavior since inside the 'get_next_alarm_date' function we check if the 'call_at' attribute from the trigger happens before 'now'. If this condition is false, i.e. if there is already an alarm set up for the future, we were returning a falsy value for the next alarm date and setting up the alarm anyway (using the current date inside '_setup_alarms', since the context was None), thus generating a new alarm with the wrong call date.
   
   After this commit, we make an extra check for recurrences in the 'get_next_alarm_date' function in order to get the correct next date for the next alarm from the next recurrent event. Additionally, if there is no next date to be called in the in the future, we skip the 'send_reminder' function which was wrongly creating another alarm using 'now' as time.
   
   Issue-from: odoo#147914
   X-original-commit: 90d5c99

   

   geflx committed Apr 29, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for ebad1e3
   • Browse repository at this point

   Copy the full SHA

   ebad1e3 View commit details

   Browse the repository at this point in the history