Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FW][IMP] website: remove navbar extra padding #163975

Closed

Conversation

fw-bot
Copy link
Contributor

@fw-bot fw-bot commented Apr 30, 2024

Description of the issue/feature this PR addresses:
In the mobile view, the header has extra padding, for this reason it is not perfectly aligned with the content of the page.

Current behavior before PR:

The header is not aligned with the content

Desktop Mobile
image image

Desired behavior after PR is merged:

The header is aligned with the content like desktop view

2024-04-28.09-07-05.mp4

I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

Forward-Port-Of: #163705

In the mobile view, the header has extra padding, for this
reason it is not perfectly aligned with the content of the page.

X-original-commit: b34ee26
@robodoo
Copy link
Contributor

robodoo commented Apr 30, 2024

@fw-bot
Copy link
Contributor Author

fw-bot commented Apr 30, 2024

This PR targets saas-17.2 and is part of the forward-port chain. Further PRs will be created up to master.

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

@robodoo robodoo added the forwardport This PR was created by @fw-bot label Apr 30, 2024
@C3POdoo C3POdoo added the RD research & development, internal work label Apr 30, 2024
@fw-bot
Copy link
Contributor Author

fw-bot commented Apr 30, 2024

@imanie383 @qsm-odoo the next pull request (#163996) is in conflict. You can merge the chain up to here by saying

@fw-bot r+

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

Copy link
Contributor

@qsm-odoo qsm-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fw-bot r+

robodoo pushed a commit that referenced this pull request Apr 30, 2024
In the mobile view, the header has extra padding, for this
reason it is not perfectly aligned with the content of the page.

closes #163975

X-original-commit: b34ee26
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
@robodoo robodoo closed this Apr 30, 2024
@qsm-odoo qsm-odoo deleted the saas-17.2-17.0-nav-imanie383-k9dz-fw branch May 2, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
forwardport This PR was created by @fw-bot RD research & development, internal work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants