[FIX] sale: Extra downpayment line

[ramaniraj11]

Issue:
======
Extra down-payment line is creating

Steps to reproduce the issue:
=============================
- create an SO, then create downpayment with 30% percent, remove the tax in generated INV and post the invoice.
- go back to SO create another downpayment with 30%

Solution:
=========
Typically, when calculating the value of down-payment lines,
we only consider sales order lines for products, not down-payment lines.
This is because, according to the Odoo workflow,
down-payment lines are created based on product lines in the sales order,
not on down-payment lines themselves. Therefore, I am filtering out those lines here.

closes odoo/odoo#163699

Description of the issue/feature this PR addresses:

Current behavior before PR:

Desired behavior after PR is merged:

---

I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

[robodoo]

Pull request status dashboard.

[MiquelRForgeFlow]

Remove [FW] from PR title.

[ramaniraj11]

Remove [FW] from PR title.

Done

[jbw-odoo]

Hi @ramaniraj11 👋
First of all, thanks for this fix, it looks great. Not a use case i had i mind, so thx for that.
2 things :

• This should target saas-16.3
• A test would be fine.

Let me know if you need help in any of this.

[ramaniraj11]

Hi @ramaniraj11 👋 First of all, thanks for this fix, it looks great. Not a use case i had i mind, so thx for that. 2 things :

• This should target saas-16.3
• A test would be fine.

Let me know if you need help in any of this.

Sorry Can you expain what are you try to say in above two point i don't understand

[jbw-odoo]

Hi @ramaniraj11 👋 First of all, thanks for this fix, it looks great. Not a use case i had i mind, so thx for that. 2 things :

• This should target saas-16.3
• A test would be fine.

Let me know if you need help in any of this.

Sorry Can you expain what are you try to say in above two point i don't understand

Yes, no worries :

Retargetting :

So this PR targets odoo 17.0 at the moment. But this fix should target odoo version saas-16.3 as this is the oldest supported version where this fix is useful. Once the fix is added to the 16.3 version of odoo, it will be forward ported to the more recent odoo versions.
To retarget you should change the base of your branch :

git fetch origin saas-16.3
git rebase --onto origin/saas-16.3 origin/17.0 17.0-fix-extra_downpayment_line_generated
git push -f

You then can change the target of this PR by clicking "Edit" and changing the "commit into" value

Test

When fixing a bug we often add a test covering the use case that is concerned.

If it's too much of a hassel, i can merge this PR and backport it to saas-16.3 + add a test myself afterwards. Let me know.

[ramaniraj11]

Hello can you please write test case and back port this code please

[jbw-odoo]

@robodoo r+