[FIX] web_editor: fix component destroy error #164151
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @sebgeelen Thank youu 🙂 |
|
The code is ok for me if you made sure this change didn't broke the urgent save. If everything is thoroughly tested and still behave as intended, then you have my 👍 |
|
@kcv-odoo You should adapt the comment since you don't use urgent anymore. |
kcv-odoo
force-pushed
the
17.0-web_editor-fix-component-destoy-error-kcv
branch
2 times, most recently
from
10a68ae
to
4e61fa1
Compare
|
@robodoo r+ |
Steps: - Install sale and editor apps. - Click on varient new button. - Add something in the description. - Discard that record. Issue: - Traceback component destroyed. Cause: - `commit_changes` does not had await on it and because of that it was performing other operations before actually commit changes and we are actully destroying record in `commit_changes` so there is no point doing other operations. Fix: - Add await and remove urgent from `commit_changes` method in-order to properly unmount component. opw-3892602
kcv-odoo
force-pushed
the
17.0-web_editor-fix-component-destoy-error-kcv
branch
from
4e61fa1
to
7e30d3c
Compare
|
Hello @dmo-odoo 👋 |
|
@robodoo r+ |
This was referenced Jun 4, 2024
lohwswilson
pushed a commit
to lohwswilson/odoo
that referenced
this pull request
Jun 5, 2024
Steps: - Install sale and editor apps. - Click on varient new button. - Add something in the description. - Discard that record. Issue: - Traceback component destroyed. Cause: - `commit_changes` does not had await on it and because of that it was performing other operations before actually commit changes and we are actully destroying record in `commit_changes` so there is no point doing other operations. Fix: - Add await and remove urgent from `commit_changes` method in-order to properly unmount component. opw-3892602 closes odoo#164151 Signed-off-by: David Monjoie (dmo) <dmo@odoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps:
Issue:
Cause:
commit_changesdoes not had await on it and because of that it was performing other operations before actually commit changes and we are actullydestroying record in
commit_changesso there isno point doing other operations.
Fix:
commit_changesmethod in-order to properly unmount component.opw-3892602
Description of the issue/feature this PR addresses:
Current behavior before PR:
Desired behavior after PR is merged:
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr