[FIX] point_of_sale: make the category images to never disappear #164189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Axel927
force-pushed
the
17.0-opw-3885493-pos_category_image-axtr
branch
from
3bfa626
to
ec6e874
Compare
Problem: In the POS session, when the screen height is below 768 px, the category images disappear Steps to reproduce: - Install "Point of Sale" app - Open a POS session and go to mobile view - Set the screen dimensions to 1024*768 px - Reduce the height of the screen to 767 px, the category image have disappeared Solution: Remove the check for a minimum size so the image is always displayed whatever be the size of the screen opw-3885493
Axel927
force-pushed
the
17.0-opw-3885493-pos_category_image-axtr
branch
from
ec6e874
to
44bfbf9
Compare
|
fw-bot ignore |
|
Forward-port disabled. |
robodoo
pushed a commit
that referenced
this pull request
May 28, 2024
Problem: In the POS session, when the screen height is below 768 px, the category images disappear Steps to reproduce: - Install "Point of Sale" app - Open a POS session and go to mobile view - Set the screen dimensions to 1024*768 px - Reduce the height of the screen to 767 px, the category image have disappeared Solution: Remove the check for a minimum size so the image is always displayed whatever be the size of the screen opw-3885493 closes #164189 Signed-off-by: Joseph Caburnay (jcb) <jcb@odoo.com>
lohwswilson
pushed a commit
to lohwswilson/odoo
that referenced
this pull request
Jun 5, 2024
Problem: In the POS session, when the screen height is below 768 px, the category images disappear Steps to reproduce: - Install "Point of Sale" app - Open a POS session and go to mobile view - Set the screen dimensions to 1024*768 px - Reduce the height of the screen to 767 px, the category image have disappeared Solution: Remove the check for a minimum size so the image is always displayed whatever be the size of the screen opw-3885493 closes odoo#164189 Signed-off-by: Joseph Caburnay (jcb) <jcb@odoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
In the POS session, when the screen height is below 768 px, the category images disappear.
Fix for V 17.0 only
Steps to reproduce:
Solution:
Remove the check for a minimum size so the image is always displayed whatever be the size of the screen
opw-3885493
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr