Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] account: different text for discounts and early payment settings #164539

Conversation

seifgneedy
Copy link
Contributor

We have two settings about discounts that are not linked to the same features (one is line discounts, and the other is Early Payment discounts). They are next to each other but not clear at all. Updating text on settings to differentiate between early payments and discounts.

Enterprise PR: https://github.com/odoo/enterprise/pull/62039

task-3908720


I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@seifgneedy seifgneedy requested a review from hupo-odoo May 6, 2024 11:54
@robodoo
Copy link
Contributor

robodoo commented May 6, 2024

Pull request status dashboard.

@C3POdoo C3POdoo added the RD research & development, internal work label May 6, 2024
@seifgneedy seifgneedy force-pushed the master-fix-discount-settings-text-segn branch from a75d346 to 4429318 Compare May 27, 2024 20:42
@hupo-odoo
Copy link
Contributor

LGTM, this task has not been tested functionnally but it quite straightforward and CHKL is on vacation, I think we can merge it for the freeze

@hupo-odoo hupo-odoo requested a review from qdp-odoo May 28, 2024 07:01
@seifgneedy seifgneedy force-pushed the master-fix-discount-settings-text-segn branch from 4429318 to a9b9b57 Compare May 28, 2024 07:25
@seifgneedy seifgneedy force-pushed the master-fix-discount-settings-text-segn branch from a9b9b57 to f784f6d Compare June 6, 2024 07:18
@seifgneedy seifgneedy changed the base branch from master to saas-17.3 June 6, 2024 07:18
We have two settings about discounts that are not linked to the same features (one is line discounts, and the other one is Early Payment discounts). They are next to each other but not clear at all.
Updating text on settings to differentiate betweeen early payments and discounts.

task-3908720
@seifgneedy seifgneedy force-pushed the master-fix-discount-settings-text-segn branch from f784f6d to 7daaf34 Compare June 10, 2024 11:26
@qdp-odoo
Copy link
Contributor

@robodoo r+

robodoo pushed a commit that referenced this pull request Jun 10, 2024
We have two settings about discounts that are not linked to the same features (one is line discounts, and the other one is Early Payment discounts). They are next to each other but not clear at all.
Updating text on settings to differentiate betweeen early payments and discounts.

task-3908720

closes #164539

Related: odoo/enterprise#62039
Signed-off-by: Quentin De Paoli <qdp@odoo.com>
@robodoo robodoo closed this Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RD research & development, internal work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants