Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] account: Allow selectable reports in Send&Print #164548

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hsal-odoo
Copy link
Contributor

@hsal-odoo hsal-odoo commented May 6, 2024

In invoices send and print wizard, this commit allows the user to select for invoice PDF template. Before this commit, only email template was selectable, and PDF template was hardcoded.

This change was needed to allow some customization when generating an invoice.

Task link
task-3879033


I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@robodoo
Copy link
Contributor

robodoo commented May 6, 2024

Pull request status dashboard.

@C3POdoo C3POdoo added the RD research & development, internal work label May 6, 2024
addons/account/wizard/account_move_send.py Outdated Show resolved Hide resolved
addons/account/wizard/account_move_send.py Outdated Show resolved Hide resolved
addons/account/wizard/account_move_send.py Outdated Show resolved Hide resolved
Copy link
Contributor

@malb-odoo malb-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments, thanks for the pr 😄

addons/account/wizard/account_move_send.py Outdated Show resolved Hide resolved
addons/account/wizard/account_move_send.py Outdated Show resolved Hide resolved
addons/account/wizard/account_move_send.py Outdated Show resolved Hide resolved
addons/account/wizard/account_move_send.py Outdated Show resolved Hide resolved
@hsal-odoo hsal-odoo force-pushed the master-account-invoice_reports-hsal branch 4 times, most recently from 2f37f7d to b3e10ee Compare May 8, 2024 13:44
@hsal-odoo hsal-odoo requested a review from malb-odoo May 8, 2024 13:44
Copy link
Contributor

@malb-odoo malb-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

again some small nitpicking here 😄 And then i think las can do the final review 😄

addons/account/wizard/account_move_send.py Outdated Show resolved Hide resolved
addons/account/wizard/account_move_send.py Outdated Show resolved Hide resolved
addons/account/wizard/account_move_send.py Outdated Show resolved Hide resolved
@hsal-odoo hsal-odoo force-pushed the master-account-invoice_reports-hsal branch from b3e10ee to 713ebda Compare May 8, 2024 15:44
@hsal-odoo hsal-odoo requested a review from malb-odoo May 8, 2024 15:53
Copy link
Contributor

@malb-odoo malb-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two small possible nitpicking and then we can Laurent for the last review 😄 Also runbot is red maybe need a rebase ?

addons/account/wizard/account_move_send.py Outdated Show resolved Hide resolved
addons/account/wizard/account_move_send.py Outdated Show resolved Hide resolved
@hsal-odoo hsal-odoo force-pushed the master-account-invoice_reports-hsal branch from 713ebda to 17a7c7e Compare May 17, 2024 14:23
@hsal-odoo hsal-odoo requested a review from malb-odoo May 17, 2024 14:24
addons/account/models/ir_actions_report.py Outdated Show resolved Hide resolved
addons/account/models/ir_actions_report.py Show resolved Hide resolved
addons/account/wizard/account_move_send.py Outdated Show resolved Hide resolved
addons/account/wizard/account_move_send.py Outdated Show resolved Hide resolved
addons/account/wizard/account_move_send.py Outdated Show resolved Hide resolved
addons/account/wizard/account_move_send.py Outdated Show resolved Hide resolved
addons/account/wizard/account_move_send.py Outdated Show resolved Hide resolved
addons/account/wizard/account_move_send.py Outdated Show resolved Hide resolved
@hsal-odoo hsal-odoo force-pushed the master-account-invoice_reports-hsal branch from 17a7c7e to 7446f1b Compare May 28, 2024 11:27
@hsal-odoo hsal-odoo requested a review from smetl May 28, 2024 11:27
In invoices send and print wizard, this commit allows the user to select for invoice PDF template.
Before this commit, only email template was selectable, and PDF template was hardcoded.

This change was needed to allow some customization when generating an invoice.

task-3879033
@hsal-odoo hsal-odoo force-pushed the master-account-invoice_reports-hsal branch from 7446f1b to f862d6b Compare May 28, 2024 11:28
Copy link
Contributor

@malb-odoo malb-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, maybe we can have a last review on this @smetl ? 😄

addons/account/wizard/account_move_send.py Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RD research & development, internal work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants