-
Notifications
You must be signed in to change notification settings - Fork 23.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IMP] account: Allow selectable reports in Send&Print #164548
base: master
Are you sure you want to change the base?
[IMP] account: Allow selectable reports in Send&Print #164548
Conversation
282304f
to
a633599
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments, thanks for the pr 😄
2f37f7d
to
b3e10ee
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
again some small nitpicking here 😄 And then i think las can do the final review 😄
b3e10ee
to
713ebda
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just two small possible nitpicking and then we can Laurent for the last review 😄 Also runbot is red maybe need a rebase ?
713ebda
to
17a7c7e
Compare
17a7c7e
to
7446f1b
Compare
In invoices send and print wizard, this commit allows the user to select for invoice PDF template. Before this commit, only email template was selectable, and PDF template was hardcoded. This change was needed to allow some customization when generating an invoice. task-3879033
7446f1b
to
f862d6b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, maybe we can have a last review on this @smetl ? 😄
In invoices send and print wizard, this commit allows the user to select for invoice PDF template. Before this commit, only email template was selectable, and PDF template was hardcoded.
This change was needed to allow some customization when generating an invoice.
Task link
task-3879033
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr