[FIX] mrp: auto-generate backorder in "always backorder" setup #164560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lase-odoo
force-pushed
the
17.0-opw-3890886-auto_back_order_production-lase
branch
from
2249c60
to
5a17203
Compare
lase-odoo
force-pushed
the
17.0-opw-3890886-auto_back_order_production-lase
branch
2 times, most recently
from
3b48acd
to
e773815
Compare
Whenrow
reviewed
May 23, 2024
addons/mrp/models/mrp_production.py
Outdated
Comment on lines
2120
to
2121
| prods_auto_backorder = [prod for prod in quantity_issues if prod.picking_type_id.create_backorder == "always"] | ||
| auto_backorders = self.env['mrp.production.backorder'].create({ |
There was a problem hiding this comment.
Suggested change
| prods_auto_backorder = [prod for prod in quantity_issues if prod.picking_type_id.create_backorder == "always"] | |
| auto_backorders = self.env['mrp.production.backorder'].create({ | |
| prods_auto_backorder = [prod for prod in quantity_issues if prod.picking_type_id.create_backorder == "always"] | |
| if prods_auto_backorder: | |
| auto_backorders = self.env['mrp.production.backorder'].create({ |
Whenrow
reviewed
May 23, 2024
addons/mrp/models/mrp_production.py
Outdated
| }) for prod in prods_auto_backorder | ||
| ], | ||
| }) | ||
| auto_backorders.action_backorder() |
There was a problem hiding this comment.
Suggested change
| auto_backorders.action_backorder() | |
| return auto_backorders.action_backorder() |
we want to open the backorder automatically at validation
Steps to reproduce: - Inventory > Configuration > Warehouse Management > Operations types - Click on Manufacturing and put "Always" on create a backorder - Create a new MO for 2 units of a product and produce 1 unit > A wizzard appears to ask you if you want to create a backorder Cause of the issue: Clicking on the produce button will call the "button_mark_done" method. However, the parameters of backorder creations are not checked before the wizzard generation: https://github.com/odoo/odoo/blob/5c2f60ae2b8eb6699bd322bc4ea3d5054c7aea37/addons/mrp/models/mrp_production.py#L2118-L2120 will call the opw-3890886
lase-odoo
force-pushed
the
17.0-opw-3890886-auto_back_order_production-lase
branch
from
e773815
to
045351e
Compare
|
Thanks a lot for the review @Whenrow ! |
|
robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
May 24, 2024
Steps to reproduce: - Inventory > Configuration > Warehouse Management > Operations types - Click on Manufacturing and put "Always" on create a backorder - Create a new MO for 2 units of a product and produce 1 unit > A wizzard appears to ask you if you want to create a backorder Cause of the issue: Clicking on the produce button will call the "button_mark_done" method. However, the parameters of backorder creations are not checked before the wizzard generation: https://github.com/odoo/odoo/blob/5c2f60ae2b8eb6699bd322bc4ea3d5054c7aea37/addons/mrp/models/mrp_production.py#L2118-L2120 will call the opw-3890886 closes #164560 Signed-off-by: William Henrotin (whe) <whe@odoo.com>
robodoo
pushed a commit
that referenced
this pull request
May 24, 2024
Steps to reproduce: - Inventory > Configuration > Warehouse Management > Operations types - Click on Manufacturing and put "Always" on create a backorder - Create a new MO for 2 units of a product and produce 1 unit > A wizzard appears to ask you if you want to create a backorder Cause of the issue: Clicking on the produce button will call the "button_mark_done" method. However, the parameters of backorder creations are not checked before the wizzard generation: https://github.com/odoo/odoo/blob/5c2f60ae2b8eb6699bd322bc4ea3d5054c7aea37/addons/mrp/models/mrp_production.py#L2118-L2120 will call the opw-3890886 closes #164560 Signed-off-by: William Henrotin (whe) <whe@odoo.com>
This was referenced May 24, 2024
|
@lase-odoo @Whenrow this pull request has forward-port PRs awaiting action (not merged or closed): |
|
@lase-odoo @Whenrow this pull request has forward-port PRs awaiting action (not merged or closed): |
lohwswilson
pushed a commit
to lohwswilson/odoo
that referenced
this pull request
Jun 5, 2024
Steps to reproduce: - Inventory > Configuration > Warehouse Management > Operations types - Click on Manufacturing and put "Always" on create a backorder - Create a new MO for 2 units of a product and produce 1 unit > A wizzard appears to ask you if you want to create a backorder Cause of the issue: Clicking on the produce button will call the "button_mark_done" method. However, the parameters of backorder creations are not checked before the wizzard generation: https://github.com/odoo/odoo/blob/5c2f60ae2b8eb6699bd322bc4ea3d5054c7aea37/addons/mrp/models/mrp_production.py#L2118-L2120 will call the opw-3890886 closes odoo#164560 Signed-off-by: William Henrotin (whe) <whe@odoo.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps to reproduce:
> A wizzard appears to ask you if you want to create a backorder
Cause of the issue:
Clicking on the produce button will call the "button_mark_done" method. However, the parameters of backorder creations are not checked before the wizzard generation:
odoo/addons/mrp/models/mrp_production.py
Lines 2118 to 2120 in 5c2f60a
opw-3890886
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr