[FIX] stock: try to reassign stolen transfer #164606
Open
+109
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
amoyaux
force-pushed
the
15.0-fix-stolen-reservation-arm
branch
from
ffff138
to
7abf4a7
Compare
Sometimes people do internal transfer to move a package inside a sub location. Use case: - Enable multi locations + packages - Create a product and put 1 unit in stock with a package PACK1 - Do a delivery (planned transfer) for this product - Create an internal transfer and move the package from WH/stock to WH/stock/shelf1 It's due to `_free_reservation` method. During the internal transfer the product is not free for usage but it exists in inventory. So it will remove the reservation from delivery and move it to the new location (+ recompute the state of reservation). However the destination location of the internal transfer could still under the delivery's source location (and could keep the reservation). We improve it by keeping in memory the move that were unreserve and we try to reverve them again after moving stuff in the internal picking WIP still need to manage it for write and create method of sml
amoyaux
force-pushed
the
15.0-fix-stolen-reservation-arm
branch
from
7abf4a7
to
9eb033a
Compare
amoyaux
commented
May 8, 2024
Comment on lines
269
to
271
| move = self.env['stock.move'].browse(vals['move_id']) | ||
| vals['picking_id'] = move.picking_id.id | ||
| vals['company_id'] = move.company_id.id |
There was a problem hiding this comment.
This part is not related to the issue but when you create a stock.move.line with a move but not the picking. The stock.move.line and the stock.picking are not linked and it could result in strange error when doing picking.move_line_ids
There was a problem hiding this comment.
seems like this part could be part of the valid sml data commit
Usecase: - Create a product with one unit available in WH/Shelf1 - Do an internal transfer for this product from WH/Shelf1 to WH/Shelf2 - Do a delivery and reserve - Go back on the internal transfer and unlock - Modify the location_dest from Shelf2 to Shelf1 Current behavior: The delivery still reserve the piece in Shelf2 and the quant has 1unit reserve but no stock Expected behavior: The delivery has the reservation to Shelf1 and only one quant exist in Shelf1
amoyaux
force-pushed
the
15.0-fix-stolen-reservation-arm
branch
from
9a2b848
to
1c971e4
Compare
It's possible to create a `stock.move.line` with both keys `picking_id` and `move_id` set but with a move not in the picking. It results in an inconcistent state
amoyaux
force-pushed
the
15.0-fix-stolen-reservation-arm
branch
from
bab08a5
to
214de21
Compare
ticodoo
reviewed
May 13, 2024
There was a problem hiding this comment.
A couple of nitpicks and I found a couple of potential bad flows with this change: https://drive.google.com/file/d/1zp9GvWmBOf-oUQzlMvTvZzT4eU9X3scy/view?usp=sharing
But otherwise it seems fine to me
Comment on lines
+765
to
+769
| moves_stolen = self.env['stock.move'] | ||
| if stolen_move_ids: | ||
| moves_stolen = self.env['stock.move'].browse(stolen_move_ids) | ||
| moves_stolen._recompute_state() | ||
| return moves_stolen |
There was a problem hiding this comment.
nitpick
Suggested change
| moves_stolen = self.env['stock.move'] | |
| if stolen_move_ids: | |
| moves_stolen = self.env['stock.move'].browse(stolen_move_ids) | |
| moves_stolen._recompute_state() | |
| return moves_stolen | |
| stolen_moves = self.env['stock.move'] | |
| if stolen_move_ids: | |
| stolen_moves = self.env['stock.move'].browse(stolen_move_ids) | |
| stolen_moves._recompute_state() | |
| return stolen_moves |
| @@ -971,7 +971,6 @@ def button_validate(self): | |||
| for picking in self: | |||
| if not picking.move_lines and not picking.move_line_ids: | |||
| pickings_without_moves |= picking | |||
|
|
|||
There was a problem hiding this comment.
whoopsies (unnecessary diff)
Comment on lines
+268
to
+269
| move = self.env['stock.move'].browse(vals['move_id']) | ||
| picking = self.env['stock.picking'].browse(vals['picking_id']) |
There was a problem hiding this comment.
Suggested change
| move = self.env['stock.move'].browse(vals['move_id']) | |
| picking = self.env['stock.picking'].browse(vals['picking_id']) | |
| move = self.env['stock.move'].browse(vals['move_id']) if vals.get('move_id') else False | |
| picking = self.env['stock.picking'].browse(vals['picking_id']) if vals.get('picking_id') else False |
Comment on lines
269
to
271
| move = self.env['stock.move'].browse(vals['move_id']) | ||
| vals['picking_id'] = move.picking_id.id | ||
| vals['company_id'] = move.company_id.id |
There was a problem hiding this comment.
seems like this part could be part of the valid sml data commit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes people do internal transfer to move a package inside a sub location.
Use case:
It's due to
_free_reservationmethod. During the internal transfer the product is not free for usage but it exists in inventory. So it will remove the reservation from delivery and move it to the new location (+ recompute the state of reservation).However the destination location of the internal transfer could still under the delivery's source location (and could keep the reservation). We improve it by keeping in memory the move that were unreserve and we try to reverve them again after moving stuff in the internal picking
WIP still need to manage it for write and create method of sml
Description of the issue/feature this PR addresses:
Current behavior before PR:
Desired behavior after PR is merged:
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr