[IMP] hr_timesheet: remove total section when timesheets are not grouped #164662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ppr-odoo
reviewed
May 7, 2024
Comment on lines
98
to
100
| <tr t-else=""> | ||
| <div style="text-align: right;" class="mr-2 mb-1 text-muted"> | ||
| <t t-if="is_uom_day"> | ||
| Total: <span t-esc="timesheets._convert_hours_to_days(hours_spent)" t-options='{"widget": "timesheet_uom"}'/> | ||
| </t> | ||
| <t t-else=""> | ||
| Total: <span t-esc="hours_spent" t-options='{"widget": "float_time"}'/> | ||
| </t> | ||
| </div> | ||
| </tr> |
There was a problem hiding this comment.
The previous code I removed. Now, I have added a new code instead of removing the else part of code.
Please check it.
Thanks
kusi-odoo
force-pushed
the
15.0-hr_timesheet-portal-fix-kusi
branch
from
4b22e83
to
0fad2cb
Compare
ppr-odoo
force-pushed
the
15.0-hr_timesheet-portal-fix-kusi
branch
from
0fad2cb
to
b6d58d7
Compare
ppr-odoo
changed the title
kusi-odoo
force-pushed
the
15.0-hr_timesheet-portal-fix-kusi
branch
from
b6d58d7
to
404b6c9
Compare
|
@kusi-odoo Please update the commit message, PR title, and description. |
kusi-odoo
force-pushed
the
15.0-hr_timesheet-portal-fix-kusi
branch
from
404b6c9
to
e0c8832
Compare
In this commit, we remove the total label in the portal view, if the timesheets are not grouped. task-3908815
kusi-odoo
force-pushed
the
15.0-hr_timesheet-portal-fix-kusi
branch
from
e0c8832
to
070a655
Compare
kusi-odoo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-In this PR, we remove the total label in the portal view, if the
timesheets are not grouped.
task-3908815